Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add routing config support to Sagemaker Endpoint Configuration #34777

Merged
merged 9 commits into from
Feb 14, 2024

Conversation

curtisallen
Copy link
Contributor

Description

Recently AWS added support for routing strategies in Sagemaker Endpoints. This PR adds routing_config support to Sagemaker Config endpoints.

Copy link

github-actions bot commented Dec 6, 2023

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added size/M Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Dec 6, 2023
@terraform-aws-provider terraform-aws-provider bot added the needs-triage Waiting for first response or review from a maintainer. label Dec 6, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome @curtisallen 👋

It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTOR guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.

Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.

Thanks again, and welcome to the community! 😃

@DrFaust92 DrFaust92 added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 7, 2023
Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, some minor changes

@curtisallen
Copy link
Contributor Author

thanks for the speedy review @DrFaust92 , please take another look 🙇🏾

@curtisallen
Copy link
Contributor Author

Happy new year @DrFaust92 gentle ping on this one 🙇🏾

Copy link
Collaborator

@DrFaust92 DrFaust92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@curtisallen
Copy link
Contributor Author

can we get a merge @DrFaust92 ?

@jar-b jar-b self-assigned this Feb 14, 2024
@terraform-aws-provider terraform-aws-provider bot added the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 14, 2024
…g test

make testacc PKG=sagemaker TESTS=TestAccSageMakerEndpointConfiguration_ProductionVariants_routing
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerEndpointConfiguration_ProductionVariants_routing'  -timeout 360m
=== RUN   TestAccSageMakerEndpointConfiguration_ProductionVariants_routing
=== PAUSE TestAccSageMakerEndpointConfiguration_ProductionVariants_routing
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_routing
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_routing (21.09s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  27.992s
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=sagemaker TESTS=TestAccSageMakerEndpointConfiguration_
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/sagemaker/... -v -count 1 -parallel 20 -run='TestAccSageMakerEndpointConfiguration_'  -timeout 360m

--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_variantNameGenerated (29.79s)
=== CONT  TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight
--- PASS: TestAccSageMakerEndpointConfiguration_namePrefix (29.82s)
--- PASS: TestAccSageMakerEndpointConfiguration_async_includeInference (33.69s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client_failurePath (36.06s)
=== NAME  TestAccSageMakerEndpointConfiguration_upgradeToEnableSSMAccess
    testing_new.go:80: Error retrieving state, there may be dangling resources: exit status 1
        Failed to marshal state to json: unsupported attribute "override_json"
--- FAIL: TestAccSageMakerEndpointConfiguration_upgradeToEnableSSMAccess (38.12s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_notif (39.89s)
--- PASS: TestAccSageMakerEndpointConfiguration_async_kms (43.91s)
--- PASS: TestAccSageMakerEndpointConfiguration_nameGenerated (47.65s)
--- PASS: TestAccSageMakerEndpointConfiguration_tags (48.80s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_routing (51.40s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_serverless (52.32s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_initialVariantWeight (23.73s)
--- PASS: TestAccSageMakerEndpointConfiguration_async (67.22s)
--- PASS: TestAccSageMakerEndpointConfiguration_dataCapture (68.80s)
--- PASS: TestAccSageMakerEndpointConfiguration_Async_client (69.09s)
--- PASS: TestAccSageMakerEndpointConfiguration_kmsKeyID (69.29s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_acceleratorType (70.69s)
--- PASS: TestAccSageMakerEndpointConfiguration_ProductionVariants_serverlessProvisionedConcurrency (76.68s)
--- PASS: TestAccSageMakerEndpointConfiguration_shadowProductionVariants (78.64s)
--- PASS: TestAccSageMakerEndpointConfiguration_basic (79.49s)
--- PASS: TestAccSageMakerEndpointConfiguration_disappears (81.61s)
FAIL
FAIL    github.com/hashicorp/terraform-provider-aws/internal/service/sagemaker  88.607s

Test failure is unrelated to this change.

@jar-b
Copy link
Member

jar-b commented Feb 14, 2024

Thanks for your contribution, @curtisallen! 🎸

@jar-b jar-b merged commit 8b5bf36 into hashicorp:main Feb 14, 2024
43 checks passed
@github-actions github-actions bot added this to the v5.37.0 milestone Feb 14, 2024
@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Feb 15, 2024
Copy link

This functionality has been released in v5.37.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/M Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants