BugFix: aws_cloudfrontkeyvaluestore_key mutex

[brittandeyoung]

Description

This change implements a mutex to make actions against cloudfront key value stores serialized.

Relations

Relates #36534

References

Output from Acceptance Testing

✗ make testacc TESTARGS='-run=TestAccCloudFrontKeyValueStore' PKG=cloudfront            
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/cloudfront/... -v -count 1 -parallel 20  -run=TestAccCloudFrontKeyValueStore -timeout 360m
=== RUN   TestAccCloudFrontKeyValueStore_basic
=== PAUSE TestAccCloudFrontKeyValueStore_basic
=== RUN   TestAccCloudFrontKeyValueStore_disappears
=== PAUSE TestAccCloudFrontKeyValueStore_disappears
=== RUN   TestAccCloudFrontKeyValueStore_comment
=== PAUSE TestAccCloudFrontKeyValueStore_comment
=== CONT  TestAccCloudFrontKeyValueStore_basic
=== CONT  TestAccCloudFrontKeyValueStore_comment
=== CONT  TestAccCloudFrontKeyValueStore_disappears
--- PASS: TestAccCloudFrontKeyValueStore_disappears (26.39s)
--- PASS: TestAccCloudFrontKeyValueStore_basic (28.42s)
--- PASS: TestAccCloudFrontKeyValueStore_comment (36.13s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront 42.219s
➜ terraform-provider-aws (b-aws_cloudfrontkeyvaluestore_key-mutex) ✗ make testacc TESTARGS='-run=TestAccCloudFrontKeyValueStoreKey' PKG=cloudfrontkeyvaluestore
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/cloudfrontkeyvaluestore/... -v -count 1 -parallel 20  -run=TestAccCloudFrontKeyValueStoreKey -timeout 360m
=== RUN   TestAccCloudFrontKeyValueStoreKey_basic
=== PAUSE TestAccCloudFrontKeyValueStoreKey_basic
=== RUN   TestAccCloudFrontKeyValueStoreKey_mutex
=== PAUSE TestAccCloudFrontKeyValueStoreKey_mutex
=== RUN   TestAccCloudFrontKeyValueStoreKey_value
=== PAUSE TestAccCloudFrontKeyValueStoreKey_value
=== RUN   TestAccCloudFrontKeyValueStoreKey_disappears
=== PAUSE TestAccCloudFrontKeyValueStoreKey_disappears
=== CONT  TestAccCloudFrontKeyValueStoreKey_basic
=== CONT  TestAccCloudFrontKeyValueStoreKey_value
=== CONT  TestAccCloudFrontKeyValueStoreKey_disappears
=== CONT  TestAccCloudFrontKeyValueStoreKey_mutex
--- PASS: TestAccCloudFrontKeyValueStoreKey_disappears (28.06s)
--- PASS: TestAccCloudFrontKeyValueStoreKey_mutex (28.39s)
--- PASS: TestAccCloudFrontKeyValueStoreKey_basic (29.11s)
--- PASS: TestAccCloudFrontKeyValueStoreKey_value (36.55s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/cloudfrontkeyvaluestore    42.382s

...

[github-actions]

Community Note

Voting for Prioritization

• Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
• Please see our prioritization guide for information on how we prioritize.
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

• Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
• For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
• Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccCloudFrontKeyValueStore_' PKG=cloudfront ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/cloudfront/... -v -count 1 -parallel 2  -run=TestAccCloudFrontKeyValueStore_ -timeout 360m
exit
=== RUN   TestAccCloudFrontKeyValueStore_basic
=== PAUSE TestAccCloudFrontKeyValueStore_basic
=== RUN   TestAccCloudFrontKeyValueStore_disappears
=== PAUSE TestAccCloudFrontKeyValueStore_disappears
=== RUN   TestAccCloudFrontKeyValueStore_comment
=== PAUSE TestAccCloudFrontKeyValueStore_comment
=== CONT  TestAccCloudFrontKeyValueStore_basic
=== CONT  TestAccCloudFrontKeyValueStore_comment
--- PASS: TestAccCloudFrontKeyValueStore_basic (57.35s)
=== CONT  TestAccCloudFrontKeyValueStore_disappears
--- PASS: TestAccCloudFrontKeyValueStore_comment (77.56s)
--- PASS: TestAccCloudFrontKeyValueStore_disappears (44.11s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfront	119.090s

% make testacc TESTARGS='-run=TestAccCloudFrontKeyValueStoreKey_' PKG=cloudfrontkeyvaluestore ACCTEST_PARALLELISM=2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.21.8 test ./internal/service/cloudfrontkeyvaluestore/... -v -count 1 -parallel 2  -run=TestAccCloudFrontKeyValueStoreKey_ -timeout 360m
=== RUN   TestAccCloudFrontKeyValueStoreKey_basic
=== PAUSE TestAccCloudFrontKeyValueStoreKey_basic
=== RUN   TestAccCloudFrontKeyValueStoreKey_mutex
=== PAUSE TestAccCloudFrontKeyValueStoreKey_mutex
=== RUN   TestAccCloudFrontKeyValueStoreKey_value
=== PAUSE TestAccCloudFrontKeyValueStoreKey_value
=== RUN   TestAccCloudFrontKeyValueStoreKey_disappears
=== PAUSE TestAccCloudFrontKeyValueStoreKey_disappears
=== CONT  TestAccCloudFrontKeyValueStoreKey_basic
=== CONT  TestAccCloudFrontKeyValueStoreKey_value
--- PASS: TestAccCloudFrontKeyValueStoreKey_basic (57.04s)
=== CONT  TestAccCloudFrontKeyValueStoreKey_disappears
--- PASS: TestAccCloudFrontKeyValueStoreKey_value (87.70s)
=== CONT  TestAccCloudFrontKeyValueStoreKey_mutex
--- PASS: TestAccCloudFrontKeyValueStoreKey_disappears (54.76s)
--- PASS: TestAccCloudFrontKeyValueStoreKey_mutex (50.71s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/cloudfrontkeyvaluestore	154.564s

[ewbankkit]

@brittandeyoung Thanks for the contribution 🎉 👏.

[lawliet89]

@brittandeyoung thank you for the fix!

[github-actions]

This functionality has been released in v5.44.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.