Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing acceptance tests after AWS SDK for Go v2 migration #38469

Merged
merged 5 commits into from
Jul 22, 2024

Conversation

ewbankkit
Copy link
Contributor

@ewbankkit ewbankkit commented Jul 22, 2024

Description

Fixes new failing acceptance tests after AWS SDK for Go v2 migration.

Relations

Closes #38468.
Relates #38343.

References

Output from Acceptance Testing

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxLustreFileSystem_metadataConfig' PKG=fsx ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxLustreFileSystem_metadataConfig -timeout 720m
=== RUN   TestAccFSxLustreFileSystem_metadataConfig
=== PAUSE TestAccFSxLustreFileSystem_metadataConfig
=== RUN   TestAccFSxLustreFileSystem_metadataConfig_increase
=== PAUSE TestAccFSxLustreFileSystem_metadataConfig_increase
=== RUN   TestAccFSxLustreFileSystem_metadataConfig_decrease
=== PAUSE TestAccFSxLustreFileSystem_metadataConfig_decrease
=== CONT  TestAccFSxLustreFileSystem_metadataConfig
=== CONT  TestAccFSxLustreFileSystem_metadataConfig_decrease
=== CONT  TestAccFSxLustreFileSystem_metadataConfig_increase
--- PASS: TestAccFSxLustreFileSystem_metadataConfig (766.93s)
--- PASS: TestAccFSxLustreFileSystem_metadataConfig_decrease (1258.42s)
--- PASS: TestAccFSxLustreFileSystem_metadataConfig_increase (1418.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1423.039s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxOpenZFSFileSystem_rootVolume\|TestAccFSxOpenZFSVolume_nfsExports' PKG=fsx ACCTEST_PARALLELISM=3 
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxOpenZFSFileSystem_rootVolume\|TestAccFSxOpenZFSVolume_nfsExports -timeout 720m
=== RUN   TestAccFSxOpenZFSFileSystem_rootVolume
=== PAUSE TestAccFSxOpenZFSFileSystem_rootVolume
=== RUN   TestAccFSxOpenZFSVolume_nfsExports
=== PAUSE TestAccFSxOpenZFSVolume_nfsExports
=== CONT  TestAccFSxOpenZFSFileSystem_rootVolume
=== CONT  TestAccFSxOpenZFSVolume_nfsExports
--- PASS: TestAccFSxOpenZFSVolume_nfsExports (831.37s)
--- PASS: TestAccFSxOpenZFSFileSystem_rootVolume (1302.94s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1307.886s
% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxONTAPStorageVirtualMachine_activeDirectoryJoin' PKG=fsx ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxONTAPStorageVirtualMachine_activeDirectoryJoin -timeout 720m
=== RUN   TestAccFSxONTAPStorageVirtualMachine_activeDirectoryJoin
=== PAUSE TestAccFSxONTAPStorageVirtualMachine_activeDirectoryJoin
=== CONT  TestAccFSxONTAPStorageVirtualMachine_activeDirectoryJoin
--- PASS: TestAccFSxONTAPStorageVirtualMachine_activeDirectoryJoin (4426.78s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	4431.381s

% ACCTEST_TIMEOUT=720m make testacc TESTARGS='-run=TestAccFSxLustreFileSystem_metadataConfig' PKG=fsx ACCTEST_PARALLELISM=3
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.22.5 test ./internal/service/fsx/... -v -count 1 -parallel 3  -run=TestAccFSxLustreFileSystem_metadataConfig -timeout 720m
=== RUN   TestAccFSxLustreFileSystem_metadataConfig
=== PAUSE TestAccFSxLustreFileSystem_metadataConfig
=== RUN   TestAccFSxLustreFileSystem_metadataConfig_increase
=== PAUSE TestAccFSxLustreFileSystem_metadataConfig_increase
=== RUN   TestAccFSxLustreFileSystem_metadataConfig_decrease
=== PAUSE TestAccFSxLustreFileSystem_metadataConfig_decrease
=== CONT  TestAccFSxLustreFileSystem_metadataConfig
=== CONT  TestAccFSxLustreFileSystem_metadataConfig_decrease
=== CONT  TestAccFSxLustreFileSystem_metadataConfig_increase
--- PASS: TestAccFSxLustreFileSystem_metadataConfig (766.93s)
--- PASS: TestAccFSxLustreFileSystem_metadataConfig_decrease (1258.42s)
--- PASS: TestAccFSxLustreFileSystem_metadataConfig_increase (1418.13s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/fsx	1423.039s
…nt 123456789012 can have at most 10240 MB/s of throughput capacity total across file systems'.
@ewbankkit ewbankkit requested a review from a team as a code owner July 22, 2024 16:11
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@terraform-aws-provider terraform-aws-provider bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. labels Jul 22, 2024
Copy link

Thank you for your contribution! 🚀

A new usage of AWS SDK for Go V1 was detected. Please prefer AWS SDK for Go V2 for all net-new services. If this is an enhancement or bug fix to an existing AWS SDK Go V1 based resource, this comment can be safely ignored.

For additional information refer to the AWS SDK for Go Versions page in the contributor guide.

Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ewbankkit ewbankkit changed the title [WIP] Fix failing acceptance tests after AWS SDK for Go v2 migration Fix failing acceptance tests after AWS SDK for Go v2 migration Jul 22, 2024
@ewbankkit ewbankkit merged commit a506c01 into main Jul 22, 2024
74 checks passed
@ewbankkit ewbankkit deleted the b-fsx-aws-sdk-go-v2-migration-regressions branch July 22, 2024 19:10
@github-actions github-actions bot added this to the v5.60.0 milestone Jul 22, 2024
Copy link

This functionality has been released in v5.60.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
service/fsx Issues and PRs that pertain to the fsx service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FSx: New failing acceptance tests after AWS SDK for Go v2 migration
2 participants