Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/aws_securityhub: Add aws_securityhub_standards_subscription #6862

Merged
merged 2 commits into from
Dec 19, 2018
Merged

r/aws_securityhub: Add aws_securityhub_standards_subscription #6862

merged 2 commits into from
Dec 19, 2018

Conversation

gazoakley
Copy link
Contributor

@gazoakley gazoakley commented Dec 14, 2018 •
edited
Loading

Partly addresses #6674

Changes proposed in this pull request:

  • New Resource: aws_securityhub_standards_subscription

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSecurityHub'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -parallel 20 -run=TestAccAWSSecurityHub -timeout 120m
=== RUN   TestAccAWSSecurityHub
=== RUN   TestAccAWSSecurityHub/Account
=== RUN   TestAccAWSSecurityHub/Account/basic
=== RUN   TestAccAWSSecurityHub/StandardsSubscription
=== RUN   TestAccAWSSecurityHub/StandardsSubscription/basic
--- PASS: TestAccAWSSecurityHub (61.12s)
    --- PASS: TestAccAWSSecurityHub/Account (22.58s)
        --- PASS: TestAccAWSSecurityHub/Account/basic (22.58s)
    --- PASS: TestAccAWSSecurityHub/StandardsSubscription (38.54s)
        --- PASS: TestAccAWSSecurityHub/StandardsSubscription/basic (38.54s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	61.168s

@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Dec 14, 2018
bflad
bflad reviewed Dec 18, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor testing things and this should be good to go. Thanks @gazoakley! 😄

aws/resource_aws_securityhub_standards_subscription_test.go Show resolved Hide resolved
aws/resource_aws_securityhub_standards_subscription_test.go Show resolved Hide resolved
aws/resource_aws_securityhub_standards_subscription_test.go Outdated Show resolved Hide resolved
aws/resource_aws_securityhub_standards_subscription_test.go Outdated Show resolved Hide resolved
@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Dec 18, 2018
@bflad bflad added this to the v1.53.0 milestone Dec 18, 2018
@bflad bflad removed the waiting-response Maintainers are waiting on response from community or contributor. label Dec 18, 2018
@bflad bflad self-requested a review December 18, 2018 20:41
@bflad bflad added new-resource Introduces a new resource. service/securityhub Issues and PRs that pertain to the securityhub service. labels Dec 18, 2018
bflad
bflad approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @gazoakley! 🚀

--- PASS: TestAccAWSSecurityHub (19.72s)
    --- PASS: TestAccAWSSecurityHub/Account (9.12s)
        --- PASS: TestAccAWSSecurityHub/Account/basic (9.12s)
    --- PASS: TestAccAWSSecurityHub/StandardsSubscription (10.59s)
        --- PASS: TestAccAWSSecurityHub/StandardsSubscription/basic (10.59s)

@bflad bflad merged commit 106ea02 into hashicorp:master Dec 19, 2018
bflad added a commit that referenced this pull request Dec 19, 2018
@bflad
Update CHANGELOG for #6862
bda51da
@bflad
Copy link
Contributor

bflad commented Dec 20, 2018

This has been released in version 1.53.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
@gazoakley gazoakley deleted the f-security-hub-standards branch April 7, 2020 16:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. new-resource Introduces a new resource. provider Pertains to the provider itself, rather than any interaction with AWS. service/securityhub Issues and PRs that pertain to the securityhub service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.53.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gazoakley @bflad