Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

service/elbv2: Support TLS protocol #7338

Merged
merged 1 commit into from
Jan 26, 2019
Merged

service/elbv2: Support TLS protocol #7338

merged 1 commit into from
Jan 26, 2019

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Jan 25, 2019

Closes #7317

Changes:

  • resource/aws_lb_listener: Add TLS to protocol argument validation
  • resource/aws_lb_target_group: Add TLS to protocol argument validation

Output from acceptance testing:

--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (26.47s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (354.32s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. labels Jan 25, 2019
@bflad bflad requested a review from a team January 25, 2019 21:02
@ghost ghost added size/L Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Jan 25, 2019
@bflad bflad mentioned this pull request Jan 25, 2019
Closed
@bflad
service/elbv2: Support TLS protocol
ea5cfc5 
Reference: #7317

Changes:
* resource/aws_lb_listener: Add `TLS` to `protocol` argument validation
* resource/aws_lb_target_group: Add `TLS` to `protocol` argument validation

Output from acceptance testing:

```
--- PASS: TestAccAWSLBTargetGroup_Protocol_Tls (26.47s)
--- PASS: TestAccAWSLBListener_Protocol_Tls (354.32s)
```
@bflad bflad added this to the v1.57.0 milestone Jan 26, 2019
@bflad bflad merged commit 7aa1371 into master Jan 26, 2019
@bflad bflad deleted the f-elbv2-tls branch January 26, 2019 01:03
bflad added a commit that referenced this pull request Jan 26, 2019
@bflad
Update CHANGELOG for #7338
0dfa32d
@bflad
Copy link
Contributor Author

bflad commented Jan 26, 2019

This has been released in version 1.57.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ewbankkit ewbankkit mentioned this pull request Jan 28, 2019
Closed
@ghost
Copy link

ghost commented Apr 1, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@paddycarver paddycarver paddycarver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/elbv2 Issues and PRs that pertain to the elbv2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v1.57.0
Development

Successfully merging this pull request may close these issues.

Add support for TLS on NLB
2 participants
@bflad @paddycarver