Final retries after timeouts in docdb resources

[ryndaniels]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Relates #7873

Release note for CHANGELOG:

BUG FIXES
* resource/aws_docdb_cluster_instance: Final retries after timeouts creating and updating DocDB cluster instances
* resource/aws_docdb_cluster_parameter_group: Final retry after timeout deleting DocDB cluster parameter groups
* resource/aws_docdb_subnet_group: Final retry after timeout deleting DocDB subnet groups

Output from acceptance testing:

$ make testacc TESTARGS="-run=TestAccAWSDocDBClusterInstance"      
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBClusterInstance -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBClusterInstance_basic
=== PAUSE TestAccAWSDocDBClusterInstance_basic
=== RUN   TestAccAWSDocDBClusterInstance_az
=== PAUSE TestAccAWSDocDBClusterInstance_az
=== RUN   TestAccAWSDocDBClusterInstance_namePrefix
=== PAUSE TestAccAWSDocDBClusterInstance_namePrefix
=== RUN   TestAccAWSDocDBClusterInstance_generatedName
=== PAUSE TestAccAWSDocDBClusterInstance_generatedName
=== RUN   TestAccAWSDocDBClusterInstance_kmsKey
=== PAUSE TestAccAWSDocDBClusterInstance_kmsKey
=== RUN   TestAccAWSDocDBClusterInstance_disappears
=== PAUSE TestAccAWSDocDBClusterInstance_disappears
=== CONT  TestAccAWSDocDBClusterInstance_basic
=== CONT  TestAccAWSDocDBClusterInstance_kmsKey
=== CONT  TestAccAWSDocDBClusterInstance_disappears
=== CONT  TestAccAWSDocDBClusterInstance_generatedName
=== CONT  TestAccAWSDocDBClusterInstance_namePrefix
=== CONT  TestAccAWSDocDBClusterInstance_az
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (575.36s)
--- PASS: TestAccAWSDocDBClusterInstance_az (680.64s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (684.96s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (701.13s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (703.06s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1406.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       1408.673s

make testacc TESTARGS="-run=TestAccAWSDocDBClusterParameterGroup"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBClusterParameterGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBClusterParameterGroup_basic
=== PAUSE TestAccAWSDocDBClusterParameterGroup_basic
=== RUN   TestAccAWSDocDBClusterParameterGroup_namePrefix
=== PAUSE TestAccAWSDocDBClusterParameterGroup_namePrefix
=== RUN   TestAccAWSDocDBClusterParameterGroup_generatedName
=== PAUSE TestAccAWSDocDBClusterParameterGroup_generatedName
=== RUN   TestAccAWSDocDBClusterParameterGroup_Description
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Description
=== RUN   TestAccAWSDocDBClusterParameterGroup_disappears
=== PAUSE TestAccAWSDocDBClusterParameterGroup_disappears
=== RUN   TestAccAWSDocDBClusterParameterGroup_Parameter
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Parameter
=== RUN   TestAccAWSDocDBClusterParameterGroup_Tags
=== PAUSE TestAccAWSDocDBClusterParameterGroup_Tags
=== CONT  TestAccAWSDocDBClusterParameterGroup_basic
=== CONT  TestAccAWSDocDBClusterParameterGroup_Parameter
=== CONT  TestAccAWSDocDBClusterParameterGroup_disappears
=== CONT  TestAccAWSDocDBClusterParameterGroup_generatedName
=== CONT  TestAccAWSDocDBClusterParameterGroup_namePrefix
=== CONT  TestAccAWSDocDBClusterParameterGroup_Description
=== CONT  TestAccAWSDocDBClusterParameterGroup_Tags
--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (23.03s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (34.53s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (34.53s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (34.54s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (34.65s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (57.72s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (79.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       81.929s

make testacc TESTARGS="-run=TestAccAWSDocDBSubnetGroup"          
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./... -v -parallel 20 -run=TestAccAWSDocDBSubnetGroup -timeout 120m
?       github.com/terraform-providers/terraform-provider-aws   [no test files]
=== RUN   TestAccAWSDocDBSubnetGroup_basic
=== PAUSE TestAccAWSDocDBSubnetGroup_basic
=== RUN   TestAccAWSDocDBSubnetGroup_disappears
=== PAUSE TestAccAWSDocDBSubnetGroup_disappears
=== RUN   TestAccAWSDocDBSubnetGroup_namePrefix
=== PAUSE TestAccAWSDocDBSubnetGroup_namePrefix
=== RUN   TestAccAWSDocDBSubnetGroup_generatedName
=== PAUSE TestAccAWSDocDBSubnetGroup_generatedName
=== RUN   TestAccAWSDocDBSubnetGroup_updateDescription
=== PAUSE TestAccAWSDocDBSubnetGroup_updateDescription
=== CONT  TestAccAWSDocDBSubnetGroup_basic
=== CONT  TestAccAWSDocDBSubnetGroup_updateDescription
=== CONT  TestAccAWSDocDBSubnetGroup_namePrefix
=== CONT  TestAccAWSDocDBSubnetGroup_generatedName
=== CONT  TestAccAWSDocDBSubnetGroup_disappears
--- PASS: TestAccAWSDocDBSubnetGroup_disappears (57.28s)
--- PASS: TestAccAWSDocDBSubnetGroup_generatedName (63.62s)
--- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (64.19s)
--- PASS: TestAccAWSDocDBSubnetGroup_basic (64.20s)
--- PASS: TestAccAWSDocDBSubnetGroup_updateDescription (99.74s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       102.895s

[bflad]

LGTM 🚀

--- PASS: TestAccAWSDocDBClusterParameterGroup_disappears (12.06s)
--- PASS: TestAccAWSDocDBSubnetGroup_disappears (15.36s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_namePrefix (18.63s)
--- PASS: TestAccAWSDocDBSubnetGroup_generatedName (22.67s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Description (25.69s)
--- PASS: TestAccAWSDocDBSubnetGroup_basic (26.26s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_generatedName (26.63s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_basic (29.02s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Parameter (29.20s)
--- PASS: TestAccAWSDocDBSubnetGroup_updateDescription (29.46s)
--- PASS: TestAccAWSDocDBSubnetGroup_namePrefix (29.40s)
--- PASS: TestAccAWSDocDBClusterParameterGroup_Tags (30.12s)
--- PASS: TestAccAWSDocDBClusterInstance_namePrefix (624.62s)
--- PASS: TestAccAWSDocDBClusterInstance_generatedName (641.30s)
--- PASS: TestAccAWSDocDBClusterInstance_disappears (671.09s)
--- PASS: TestAccAWSDocDBClusterInstance_kmsKey (689.66s)
--- PASS: TestAccAWSDocDBClusterInstance_az (712.43s)
--- PASS: TestAccAWSDocDBClusterInstance_basic (1266.66s)

[ghost]

This has been released in version 2.24.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!