Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependencies: Update recoveryservices to 2021-12-01/backup #16001

Merged
merged 1 commit into from
May 6, 2022

Conversation

myc2h6o
Copy link
Contributor

@myc2h6o myc2h6o commented Mar 24, 2022

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Mar 25, 2022

Test result:
image

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we have 2 failing tests:

image

we may need to add an additional wait on delete for the first failure, but try merging main first as that check should be turned off on main

@myc2h6o
Copy link
Contributor Author

myc2h6o commented Apr 26, 2022

Hi @katbyte TestAccBackupProtectedVm_separateResourceGroups is being fixed by #16552 TestAccRecoveryServicesVault_switchEncryptionKeyVaultKey is being fixed by #16545 I'll rerun the test for this change after those two are merged

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @myc2h6o - LGTM 🌿

@katbyte katbyte merged commit 77706a0 into hashicorp:main May 6, 2022
@github-actions github-actions bot added this to the v3.5.0 milestone May 6, 2022
katbyte added a commit that referenced this pull request May 6, 2022
@github-actions
Copy link

github-actions bot commented May 6, 2022

This functionality has been released in v3.5.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@myc2h6o myc2h6o deleted the recover_service_backup_api branch May 6, 2022 01:41
@github-actions
Copy link

github-actions bot commented Jun 5, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants