Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_api_management_api_tag_description support config API tag description #17876

Merged
merged 13 commits into from
Sep 6, 2022

Conversation

xuzhang3
Copy link
Contributor

@xuzhang3 xuzhang3 commented Aug 4, 2022

Support config API tag description

=== RUN   TestAccApiManagementApiTagDescription_basic
=== PAUSE TestAccApiManagementApiTagDescription_basic
=== RUN   TestAccApiManagementApiTagDescription_requiresImport
=== PAUSE TestAccApiManagementApiTagDescription_requiresImport
=== RUN   TestAccApiManagementApiTagDescription_update
=== PAUSE TestAccApiManagementApiTagDescription_update
=== CONT  TestAccApiManagementApiTagDescription_basic
=== CONT  TestAccApiManagementApiTagDescription_update
=== CONT  TestAccApiManagementApiTagDescription_requiresImport
--- PASS: TestAccApiManagementApiTagDescription_requiresImport (573.86s)
--- PASS: TestAccApiManagementApiTagDescription_basic (579.79s)
--- PASS: TestAccApiManagementApiTagDescription_update (661.20s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement 701.001s

@xuzhang3 xuzhang3 changed the title [new resource] azurerm_api_management_api_tag_description support config API tag description New Resource: azurerm_api_management_api_tag_description support config API tag description Aug 18, 2022
@xuzhang3 xuzhang3 requested a review from katbyte August 30, 2022 09:15
Signed-off-by: Zooopx <xuzhang3@microsoft.com>
Signed-off-by: Zooopx <xuzhang3@microsoft.com>
@xuzhang3
Copy link
Contributor Author

xuzhang3 commented Sep 5, 2022

=== RUN   TestAccApiManagementApiTagDescription_basic
=== PAUSE TestAccApiManagementApiTagDescription_basic
=== RUN   TestAccApiManagementApiTagDescription_requiresImport
=== PAUSE TestAccApiManagementApiTagDescription_requiresImport
=== RUN   TestAccApiManagementApiTagDescription_update
=== PAUSE TestAccApiManagementApiTagDescription_update
=== CONT  TestAccApiManagementApiTagDescription_basic
=== CONT  TestAccApiManagementApiTagDescription_update
=== CONT  TestAccApiManagementApiTagDescription_requiresImport
--- PASS: TestAccApiManagementApiTagDescription_basic (540.66s)
--- PASS: TestAccApiManagementApiTagDescription_requiresImport (565.15s)
--- PASS: TestAccApiManagementApiTagDescription_update (660.92s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/apimanagement 662.854s

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xuzhang3 - LGTM 🏷️

@katbyte katbyte merged commit 58c52ee into hashicorp:main Sep 6, 2022
@github-actions github-actions bot added this to the v3.22.0 milestone Sep 6, 2022
katbyte added a commit that referenced this pull request Sep 6, 2022
@github-actions
Copy link

github-actions bot commented Sep 9, 2022

This functionality has been released in v3.22.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 10, 2022
@xuzhang3 xuzhang3 deleted the f/api_tag_desc branch August 14, 2024 02:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants