Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance: azurerm_api_management - Support additional_location.gateway_disabled, certificate_source, certificate_status #18508

Merged
merged 3 commits into from
Sep 29, 2022
Merged

Enhance: azurerm_api_management - Support additional_location.gateway_disabled, certificate_source, certificate_status #18508

merged 3 commits into from
Sep 29, 2022

Conversation

xuzhang3
Copy link
Contributor

Support config gateway_disabled, certificate_status, certificat

=== RUN   TestAccApiManagement_additionalLocationGateway
=== PAUSE TestAccApiManagement_additionalLocationGateway
=== CONT  TestAccApiManagement_additionalLocationGateway
--- PASS: TestAccApiManagement_additionalLocationGateway (5274.84s)
PASS

@xuzhang3 xuzhang3 changed the title Enhance: azurerm_api_management - Support gateway_disabled, certificate_source, certificate_status Enhance: azurerm_api_management - Support additional_location.gateway_disabled, certificate_source, certificate_status Sep 23, 2022
katbyte
katbyte approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💎

katbyte
katbyte requested changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually missed a potential panic, comment inline

@xuzhang3
Copy link
Contributor Author

actually missed a potential panic, comment inline

you may forgot to submit the commend 😄

katbyte
katbyte approved these changes Sep 29, 2022
View reviewed changes
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦕

@katbyte katbyte merged commit 3eb9806 into hashicorp:main Sep 29, 2022
@github-actions github-actions bot added this to the v3.25.0 milestone Sep 29, 2022
katbyte added a commit that referenced this pull request Sep 29, 2022
@katbyte
CHANGELOG #18508
a0ff111
@github-actions
Copy link

This functionality has been released in v3.25.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2022
@xuzhang3 xuzhang3 deleted the f/apim_enhance branch August 14, 2024 02:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@katbyte katbyte katbyte approved these changes

Assignees
No one assigned
Labels
documentation service/api-management
Projects
None yet
Milestone
v3.25.0
Development

Successfully merging this pull request may close these issues.
2 participants
@xuzhang3 @katbyte