New Resource: azurerm_site_recovery_replication_recovery_plan;New Data Source: azurerm_site_recovery_replication_recovery_plan

[ziyeqf]

Test

TF_ACC=1 go test -parallel 10 -v ./internal/services/recoveryservices -run=RecoveryPlan -timeout '720m' -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccSiteRecoveryReplicationRecoveryPlan_basic
=== PAUSE TestAccSiteRecoveryReplicationRecoveryPlan_basic
=== RUN   TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions
=== PAUSE TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions
=== RUN   TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions
=== PAUSE TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_basic
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions (2870.90s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_basic (3267.83s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions (4353.15s)
PASS
ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices

data source

 TF_ACC=1 go test -v ./internal/services/recoveryservices -run=TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_basic -timeout=600m
=== RUN   TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_basic
=== PAUSE TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_basic
=== CONT  TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_basic
--- PASS: TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_basic (2746.93s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      2748.085s

[ziyeqf]

close and will reopen when the test finish

[ms-zhenhua]

Not quite understand the second sentence. group_type is one element of recovery_group, so each recovery_group has a group_type ?

[ziyeqf]

yes, and there should be at least three recovery_group Maybe we can make recovery_group a computed one to avoid this?

[ms-zhenhua]

Can it be computed? Isn't recovery_group a configurable property?

[ziyeqf]

I remember there is some trouble as it's typeSet.. if I set it to computed there might be a diff, let me give it a try.

[ms-zhenhua]

The default hash for Set will ignore the computed properties. The problem is: if this property is configurable by users, it should not be set as computed?

[ziyeqf]

it's configurable and if the users do not configure it, it will also be generated by service.
My problem is the block, I want to set it to computed then the users have no need to add blocks they do not use in their config file.
while in this situation, it get response with 3 recovery_group, but only one in the config file, then there will be a diff.

[ms-zhenhua]

Souds like a backend problem. Normally, the backend should not change the configuration sent by the frontend.

[ziyeqf]

convert to draft to re run tests

[ziyeqf]

new test result

=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_basic
=== CONT  TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions
--- PASS: TestAccDataSourceSiteRecoveryReplicationRecoveryPlan_basic (2679.47s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_withPostActions (2679.93s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_basic (2680.92s)
--- PASS: TestAccSiteRecoveryReplicationRecoveryPlan_withPreActions (2864.01s)
PASS
ok      github.com/hashicorp/terraform-provider-azurerm/internal/services/recoveryservices      2865.193s

[khouloudbo]

Hello, the azurerm recovery plan still not supported in the new version (3.39.1) ?

[katbyte]

LGTM 💾

[github-actions]

This functionality has been released in v3.41.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.