azurerm_eventhub - changing partition_count now creates a new resource #20480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build failure Found new usages of deprecated functionality: https://github.com/hashicorp/terraform-provider-azurerm/actions/runs/4185390377 |
|
hey @unique-dominik Thanks for this PR - sorry to ask so soon after opening, but would you mind rebasing this PR on top of We've been trying to diagnose an issue with Github Actions that necessitated breaking the Thanks! |
Sure no worries, ping me when to rebase 👍 Edit: I also do that often so full understanding from my side 🤣 #actionsFun |
|
@unique-dominik |
|
@tombuildsstuff I did "sync" with the GH UI. It is up to date even though not rebased yet. |
katbyte
changed the title
|
This functionality has been released in v3.44.0 of the Terraform Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
asleekgeek
pushed a commit
to asleekgeek/terraform-provider-azurerm
that referenced
this pull request
Feb 17, 2023
* `azurerm_mssql_managed_instance` - fix use `administrator_password` instead of `administrator_login_password` issue (hashicorp#20232) Fix hashicorp#20181 * [New resource] - `azurerm_machine_learning_datastore_fileshare` Support Machine learning datastore fileshare (hashicorp#19934) Co-authored-by: xuzhang3 <Zhangxu894765> * CHANGELOG hashicorp#19934 * redis: refactoring to use `hashicorp/go-azure-sdk` (hashicorp#20313) Co-authored-by: kt <kt@katbyte.me> * CHANGELOG hashicorp#20313 * `azurerm_dashboard_grafana` - Support `grafana_integrations` (hashicorp#20102) * [New resource] - `azurerm_machine_learning_datastore_datalake_gen2` (hashicorp#20045) Co-authored-by: xuzhang3 <Zhangxu894765> Co-authored-by: kt <kt@katbyte.me> * CHANGELOG hashicorp#20045 * `azurerm_sentinel_alert_rule_nrt`, `azurerm_sentinel_alert_rule_scheduled`: support `dynamic_property` (hashicorp#20212) * CHANGELOG * datadog: refactoring to use `hashicorp/go-azure-sdk` (hashicorp#20311) Co-authored-by: kt <kt@katbyte.me> * CHANGELOG hashicorp#20311 * `azurerm_sentinel_alert_rule_nrt`, `azurerm_sentinel_alert_rule_scheduled`: support `sentinel_entity_mapping` (hashicorp#20230) * CHANGELOG hashicorp#20230 * `azurerm_monitor_scheduled_query_rules_alert` - fix `query_type` (hashicorp#20290) resolves hashicorp#20267 * `databricks`: Update API to `2023-02-01`, except accessconnectors (hashicorp#20309) Co-authored-by: kt <kt@katbyte.me> * CHANGELOG hashicorp#20309 * New Resource: `azurerm_mobile_network`; New DataSource: `azurerm_mobile_network`; (hashicorp#20128) * CHANGELOG hashicorp#20128 * `azurerm_web_application_firewall_policy` - fix failure caused by order change of `disabled_rules` (hashicorp#20285) fix hashicorp#20183 * CHANGELOG hashicorp#20285 * `azurerm_storage_blob_inventory_policy` - add `exclude_prefixes` to `filter` resource block (hashicorp#20281) Co-authored-by: Harshavardhan Musanalli <Harshavardhan.Musanalli@amadeus.com> Fixes hashicorp#20276 * CHANGELOG hashicorp#20281 * `azurerm_media_streaming_locator` - support for `filter_names` property (hashicorp#20274) Co-authored-by: Zhenhua Hu <zhhu@microsoft.com> * CHANGELOG hashicorp#20274 * New Resource: `azurerm_sentinel_data_connector_microsoft_threat_intelligence` (hashicorp#20273) * CHANGELOG hashicorp#20273 * `azurerm_media_live_event_output` - support for `rewind_window_duration` property (hashicorp#20271) * CHANGELOG hashicorp#20271 * `azurerm_disk_encryption_set` - remove unnecessary validation on key vault purge protection (hashicorp#20253) fix hashicorp#20250 * `azurerm_media_streaming_live_event` - support for `stream_options` property (hashicorp#20254) * CHANGELOG hashicorp#20254 * `azurerm_shared_image`: support `confidential_vm_supported` and `confidential_vm_enabled` (hashicorp#20249) * CHANGELOG hashicorp#20249 * `azurerm_log_analytics_workspace` - add state migration for sdk update (hashicorp#20246) Fix hashicorp#20240 * `databoxedge` - switch to `hashicorp/go-azure-sdk` (hashicorp#20236) Co-authored-by: kt <kt@katbyte.me> * CHANGELOG hashicorp#20236 * `azurerm_sentinel_alert_rule_nrt` - support block `event_grouping` (hashicorp#20231) Co-authored-by: kt <kt@katbyte.me> * CHANGELOG hashicorp#20231 * New Service: `Containerapps` (hashicorp#18008) * Update for hashicorp#18008 * fix counter_specifiers doc (hashicorp#20352) * fix files that are not resources but sound like they are (for tooling) (hashicorp#20346) * Dependencies: bump app_service to `2021-03-01` (hashicorp#20349) * Update for hashicorp#20349 * `azurerm_spring_cloud_app` - normalize `addon_json` (hashicorp#20335) * `azurerm_service_fabric_managed_cluster` - Fix potential panic when setting `node_type` (hashicorp#20345) * Update changelog for hashicorp#20345 * `azurerm_databricks_access_connector` : the `identity ` property should be optional rather than required (hashicorp#20342) * fix issue 20308 * update code * update code * Fix api_management_custom_domain timeout length that was too short (hashicorp#20348) * Update api_management_custom_domain_resource.go Extended the timeout from 45 min to 60 min * Update api_management_custom_domain.html.markdown Updated the documentation * Upgrade Postgresql Flexible Server AAD Administrator API version from 2022-03-08-preview to 2022-12-01 (hashicorp#20367) * update changelog for hashicorp#20367 * fixes hashicorp#20351 - Update length to 64 for databricks_access_controller_name (hashicorp#20353) * issue/20351 - Update name length to 64 * Update test * update changelog for hashicorp#20353 * Updating based on df53c82b * Doc FIx (hashicorp#20378) * dependencies: updating to `v0.20230208.1165725` of `github.com/hashicorp/go-azure-sdk` / `v0.20230208.1135849` of `github.com/tombuildsstuff/kermit` (hashicorp#20381) * Update changelog for hashicorp#20381 * Update go-azure-sdk * Migrate to new base layer and auth package * Fix up environment usages in clients and resources * Support for `client_certificate` and `use_cli` provider properties. Tweaks to auth guides. * sorting the changelog * `azurerm_postgresql_flexible_server` - support `replication_role` and new enum value `Replica` for `create_mode` (hashicorp#20364) * azurerm_postgresql_flexible_server - support for new properties replicationRole and replicaCapacity * update code * update code * update code * update code * update code * update code * Update CHANGELOG.md * Fixed storage_container_id in docs, fixed typo in markdown file name (hashicorp#20391) * `batch` - switch over to `hashicorp/go-azure-sdk` (hashicorp#20375) * add batch go-azure-sdk * fix lint errors * fix wait condition for pools * finish swapping over batch * dependencies: updating to `v0.20230208.1165725` of `github.com/hashicorp/go-azure-sdk` / `v0.20230208.1135849` of `github.com/tombuildsstuff/kermit` (hashicorp#20381) * cherry picked go-azure-sdk upgrade * nil check os_disk_placement * Update for hashicorp#20375 * Upgrade Postgresql Flexible Server Database API version from 2021-06-01 to 2022-12-01 (hashicorp#20369) * Upgrade Postgresql Flexible Server Database API version from 2021-06-01 to 2022-12-01 * update code * update for hashicorp#20369 * `Docs`: udpate `azurerm_key_vault_access_policy` object_id description for principal app (hashicorp#20366) * udpate keyvault access policy resource object for principal app * fix doc typo * v3.43.0 * New Resource `azurerm_network_manager_security_admin_configuration`, `azurerm_network_manager_admin_rule_collection`, `azurerm_network_manager_admin_rule` (hashicorp#20233) * CHANGELOG hashicorp#20233 * `storage` - Parse Property Case Insensitively in `Read` (hashicorp#20247) * `azurerm_kubernetes_cluster_node_pool`: Allow multiple subnets within pool vnet (test + docs) (hashicorp#20333) Fixes hashicorp#20330 * New Resource: `azurerm_mobile_network_site`; New Data Source: `azurerm_mobile_network_site` (hashicorp#20334) * CHANGELOG $20334 * `azurerm_express_route_port` - support for the `billing_type` property (hashicorp#20361) Co-authored-by: xuzhang3 <Zhangxu894765> * CHANGELOG hashicorp#20361 * `azurerm_batch_pool`: fix index out of range panic when read from nil slice (hashicorp#20362) Fixes hashicorp#20329 * [Fix] - `azurerm_machine_learning_workspace` - Remove `image_build_compute_name` forceNew constraint (hashicorp#20371) Co-authored-by: xuzhang3 <Zhangxu894765> * `azurerm_site_recovery_protection_container_mapping`: remove ForceNew of `automatic_update.automation_account_id` (hashicorp#20383) fix hashicorp#20357 * azurerm_postgresql_flexible_server_active_directory_administrator - add locks to fix concurrent issue (hashicorp#20384) * r/management_locks: refactoring to use `hashicorp/go-azure-sdk` (hashicorp#20387) * CHANGELOG hashicorp#20387 * `azurerm_sentinel_data_connector_threat_intelligence` - support `lookback_date` (hashicorp#20390) fix hashicorp#19795 * Migrate botservice sdk from azure sdk track1 to kermit * make fmt * Upgrade Postgresql Flexible Server Firewall Rule API version from 2021-06-01 to 2022-12-01 (hashicorp#20370) * update for hashicorp#20370 * dependencies: updating to `v0.20230210.1121632` of `github.com/hashicorp/go-azure-sdk` * r/private_endpoint: normalizing the private_connection_resource_id for a redis cache Fixes hashicorp#20413 * Containerapps: Corrections and additions to docs (hashicorp#20411) * Fix the validation for Event Grid Topic Name (hashicorp#20407) The validation is currently rejecting Event Grid Topic Names more than 50 characters in length, but the actual limit is 128 characters. * update for hashicorp#20407 * golint: updating to 1.51.1 * updating to include hashicorp#20417 * added validations for admin_username linux and windows virtual machines according to Azure API * Add 'DC0' to available SKU options * Add information about 'DC0' SKU to document * doc enhancement * Update kermit to v0.20230208.1135849 & remove nolint comments * fix fmt error * Add resource_manager_id towards storage queue readme Based on this PR hashicorp#19969 * `azurerm_kubernetes_cluster` - update version in test cases (hashicorp#20432) * `azurerm_kubernetes_cluster` - update version in test cases * update test case's name * updating to include hashicorp#20418 * linting: fixing bugs caught by golint-ci * New Datasource: `azurerm_hybrid_compute_machine` (hashicorp#20211) * hybrid compute datasource * update on dependencies * Add document template for hybridcompute * Update document and testcase * Update on settings file and test case * Update on property name and script format * Update based on CI report * Update based on CI report * Update website/docs/d/hybrid_compute_machine.html.markdown Co-authored-by: Zhenhua Hu <zhhu@microsoft.com> * Update website/docs/d/hybrid_compute_machine.html.markdown Co-authored-by: Zhenhua Hu <zhhu@microsoft.com> * Remove forcenew for datasource * Update property type to Bool * Update internal/services/hybridcompute/hybrid_compute_machine_data_source_test.go Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/hybridcompute/scripts/install_arc.sh.tmpl Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/hybridcompute/hybrid_compute_machine_data_source.go Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/hybridcompute/hybrid_compute_machine_data_source.go Co-authored-by: Tom Bamford <tom@bamford.io> * Remove extension property and change mssql_discovered to bool * Update internal/services/hybridcompute/hybrid_compute_machine_data_source.go Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/hybridcompute/hybrid_compute_machine_data_source.go Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/hybridcompute/hybrid_compute_machine_data_source.go Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/hybridcompute/hybrid_compute_machine_data_source.go Co-authored-by: Tom Bamford <tom@bamford.io> * Update internal/services/hybridcompute/scripts/install_arc.sh.tmpl Co-authored-by: Tom Bamford <tom@bamford.io> * Update template file * Add testcase and improve security * Fix golint error * Update internal/services/hybridcompute/scripts/install_arc.sh.tftpl --------- Co-authored-by: Zhenhua Hu <zhhu@microsoft.com> Co-authored-by: Tom Bamford <tom@bamford.io> * Changelog for hashicorp#20211 * internal/clients: removing the unused `ResourceManagerEnvironment` field This is unused * updating to include hashicorp#20426 * go mod vendor * `azurerm_hpc_cache` - add nil check when `usernameSource` is `None` (hashicorp#20428) * Data Source: `azurerm_policy_definition` - support for `mode` property (hashicorp#20420) * CHANGELOG hashicorp#20420 * Changelog for hashicorp#23320 * `azurerm_storage_account`: fix environment check for `allow_nested_items_to_be_public`/`min_tls_version` checks (hashicorp#20443) * update go-azure-sdk to v0.20230213.1235936 (hashicorp#20444) * Update changelog for hashicorp#20444 * fix TestAccVirtualNetworkGatewayConnection_sitetositeWithoutSharedKey * TestCase: fix TCs of azurerm_netapp_volume (hashicorp#20446) * fix: minor spelling mistakes in storage_management_policy docs (hashicorp#20445) * `azurerm_private_endpoint` - read private endpoint connection insensitively * fix: azurerm_storage_management_policy requires blobType filter (hashicorp#20448) Fixes hashicorp#20447 * updating to include hashicorp#20424 * dependencies: updating to `v0.20230214.1110923` of `github.com/hashicorp/go-azure-sdk` * CI - increase parallelism for `containerapps` after quota increase (hashicorp#20450) * dependencies: updating to `v0.20230214.1122756` of `github.com/hashicorp/go-azure-sdk` * New Resource: `azurerm_mobile_network_slice`; New Data Source: `azurerm_mobile_network_slice` (hashicorp#20336) * New Resource: `azurerm_mobile_network_slice` * limit acctest location * fix docs and error output * refresh vendor * update code * update code * doc update * media: refactoring to use API Version `2022-08-01` for `StreamingEndpoints` * dependencies: removing `media` @ `2020-05-01` since this is no longer used * update changelog for hashicorp#20336 * Fix generate * `azurerm_recovery_services_vault` - add limit on `cross_region_restore_enabled` (hashicorp#20406) * `azurerm_recovery_services_vault` - add limit on `cross_region_restore_enabled` * golint * Update for hashicorp#20406 and hashicorp#20448 * updating to include hashicorp#20456 * provider: validating that the schema doesn't contain an `encryption` block marked as Computed These should instead be marked as `Computed: false` and use delta/patch updates - allowing users to use `ignore_changes` across the Provider whilst there's a subset of resources which support this today - these have been temporarily excluded to allow this to be fixed in 4.0 * updating to include hashicorp#20457 * provider: expanding the `encryption` block schema validation test * provider: removing the resource schema exceptions when in 4.0 mode This'll make this obvious when we look to enable the feature-flags * updating to include hashicorp#20452 * New Resource: `azurerm_mobile_network_sim_group`; New DataSource: `azurerm_mobile_network_sim_group` (hashicorp#20339) * New Resource: `azurerm_mobile_network_sim_group`; New DataSource: `azurerm_mobile_network_sim_group` * remove unused forcenew * refresh vendor * update schema * update code * update code * update changelog for hashicorp#20339 * Updating based on fa9aac62 * internal: data sources should surface an error rather than using d.SetID("") Since we're looking up a particular resource by it's details, if it's not found we should return an error, unfortunately these data sources haven't been doing that due to the broken script - so this commit fixes both the data sources and the script to validate that Data Sources don't use `d.SetID("")` * scripts: updating the gradually deprecated check to check typed data sources too * services: fixing the typed data sources which are using `MarkAsGone` rather than returning an error when the resource can't be found * testing: adding an explicit exit 1 to ensure the linters running * tooling: running the gradually deprecated command via bash so we get an exit code * sanity checking * Update scripts/run-gradually-deprecated.sh Co-authored-by: Tom Bamford <tom@bamford.io> * Update scripts/run-gradually-deprecated.sh Co-authored-by: Tom Bamford <tom@bamford.io> * updating to include hashicorp#20479 * fix: removing the (intentional) `exit 1` from `run-gradually-deprecated` * tooling: running when the script changes too * r/kubernetes_cluster: parsing the `log_analytics_workspace_id` response insensitively to fix hashicorp#20478 * updating to include hashicorp#20484 * removing the new data sources which haven't shipped yet from the bugfixes section these are new, so the bug existed only in `main` which hasn't shipped yet * Updating based on a746e232 * `azurerm_backup_protected_vm` - fix a bug during deletion (hashicorp#20469) * Update changelog for hashicorp#20469 * update go-azure-sdk (hashicorp#20499) * `azurerm_kubernetes_cluster` - mark `dns_zone_id` optional (hashicorp#20341) * `azurerm_kubernetes_cluster` - mark `dns_zone_id` optional * update * fix testcase * Update for hashicorp#20341 * Update go-azure-sdk * Bugfix: fall back to retrieving objectID of authenticated principal from MS Graph This is still needed when authenticating between tenants, i.e. the authentication principal (application or user) is homed in a different tenant to the authorizing tenant, as the `oid` claim is often missing. Additionally, fall back to configuring tenantID and clientID from user-supplied values in the event those claims are also absent from the access token. * internal/clients: updating the method signature * internal/clients: calling the cancel func This isn't ideal, but since the timeout provided to the provider isn't necessarily surrounded by a context (and is threaded through) adding this context at this point seems reasonable for now * updating to include hashicorp#20465 * `azurerm_data_factory_linked_service_azure_blob_storage` - Add support for `connection_string_insecure` (hashicorp#20494) * Update changelog for hashicorp#20494 * `azurerm_postgresql_flexible_server` - update `ForceNew` for `create_mode` and `version` (hashicorp#20495) * New Data Source `azurerm_virtual_desktop_host_pool` (hashicorp#20505) Co-authored-by: Alex Wilcox <alex.wilcox@cloudsecure.ltd> * CHANGELOG hashicorp#20505 * r/private_endpoint: updating the resource provider name (hashicorp#20504) * `datashare` - switch to use `hashicorp/go-azure-sdk` (hashicorp#20501) * CHANGELOG hashicorp#20501 * Update eventhub_resource.go (hashicorp#20480) * CHANGELOG hashicorp#20480 * data source `azurerm_key_vault_secrets`, `azurerm_key_vault_certificates` - expose certificates block (hashicorp#20498) * CHANGELOG hashicorp#20498 * `azurerm_role_definition` - Add conversion check to avoid nil panic (hashicorp#20468) * TestCase: fix acctest of azurerm_netapp_volume (hashicorp#20458) * azurerm_nginx_configuration - fix package_data, protected_file validation logic (hashicorp#20491) * New Resource: `azurerm_mobile_network_service`; New DataSource: `azurerm_mobile_network_service` (hashicorp#20337) * CHANGELOG hashicorp#20337 * `azurerm_route_table`: support `next_hop_in_ip_address` value as nil (hashicorp#20365) * `azurerm_container_app`: add identity field to registry block (hashicorp#20466) * CHANGELOG hashicorp#20466 * update policy def datasource docs and error messages (hashicorp#20510) * New Resource: `azurerm_site_recovery_services_vault_hyperv_site` (hashicorp#20430) * New Resource: `azurerm_site_recovery_services_vault_hyperv_site` * extend delete timeout * CHANGEOG #204309 * `azurerm_api_management`: introduction of the `delegation` block (hashicorp#20399) * CHANGELOG hashicorp#20399 * New Data Source: `azurerm_policy_definition_built_in` (hashicorp#19933) * CHANGELOG hashicorp#19933 * `azurerm_mssql_managed_instance` : fix acc test failure for priority changed after apply (hashicorp#20033) * `azurerm_container_app` - allow multiple `container` blocks (hashicorp#20423) * CHANGELOG hashicorp#20423 * Update CHANGELOG.md * v3.44.0 * Update CHANGELOG.md * `azurerm_kubernetes_cluster` - fix crash when security profile is nil * Doc: fix import specs * updating to include hashicorp#20517 * dependencies: updating to `v0.20230217.1092053` of `github.com/hashicorp/go-azure-sdk` * updating to include hashicorp#20523 * appconfiguration: surfacing an error when one exists, rather than misleadingly marking the app configuration as gone * Update to latest go-azure-sdk * Bugfix: source the tenant ID, subscription ID and client ID from Azure CLI as needed * Changelog for hashicorp#20526 * r/logic_app_standard: using the domainSuffix rather than the endpoint * r/synapse_role_assignment: using domainSuffix rather than endpoint * dependencies: updating to `v0.20230217.1150808` of `github.com/hashicorp/go-azure-sdk` * updating to include hashicorp#20533 * updating to include hashicorp#20539 * updating to include hashicorp#20536 * updating to include hashicorp#20523 * v3.44.1 --------- Co-authored-by: Elena Xin <39109137+sinbai@users.noreply.github.com> Co-authored-by: xuzhang3 <57888764+xuzhang3@users.noreply.github.com> Co-authored-by: kt <kt@katbyte.me> Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com> Co-authored-by: Zhenhua Hu <zhhu@microsoft.com> Co-authored-by: ziyeqf <51212351+ziyeqf@users.noreply.github.com> Co-authored-by: Tao <104055472+teowa@users.noreply.github.com> Co-authored-by: Vladimir Lazarenko <favoretti@users.noreply.github.com> Co-authored-by: Harshavardhan Musanalli <harshavmb@gmail.com> Co-authored-by: Yichun Ma <yicma@microsoft.com> Co-authored-by: stephybun <steph@hashicorp.com> Co-authored-by: jackofallops <11830746+jackofallops@users.noreply.github.com> Co-authored-by: Heng Lu <79895375+ms-henglu@users.noreply.github.com> Co-authored-by: magodo <wztdyl@sina.com> Co-authored-by: Matthew Frahry <mbfrahry@gmail.com> Co-authored-by: Lukas Duus <115475014+linak-lukasmendez@users.noreply.github.com> Co-authored-by: Neil Ye <yechenwei2007@hotmail.com> Co-authored-by: catriona-m <86247157+catriona-m@users.noreply.github.com> Co-authored-by: Theo Andresier <49570057+Threpio@users.noreply.github.com> Co-authored-by: hc-github-team-tf-azure <> Co-authored-by: Tom Bamford <tom@bamford.io> Co-authored-by: Maksymilian Foltyn <maxfoltyn@gmail.com> Co-authored-by: Xu Wu <xuwu1@microsoft.com> Co-authored-by: aristosvo <8375124+aristosvo@users.noreply.github.com> Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu> Co-authored-by: Audun Solemdal <audun@solom.no> Co-authored-by: Zac <zpbd@users.noreply.github.com> Co-authored-by: Juanjo <juanjo@generacionred.com> Co-authored-by: Ding Liu <contact@ding-liu.me> Co-authored-by: ziyeqf <zyqf16@gmail.com> Co-authored-by: Pascal Lagerweij <pascallagerweij@gmail.com> Co-authored-by: Yun Liu <yunliu1@microsoft.com> Co-authored-by: Jared Holgate <jaredholgate@microsoft.com> Co-authored-by: Cary Symes <CSymes@users.noreply.github.com> Co-authored-by: Alex <38583982+alexwilcox9@users.noreply.github.com> Co-authored-by: Alex Wilcox <alex.wilcox@cloudsecure.ltd> Co-authored-by: Dominik from Unique <dominik@unique.ch> Co-authored-by: lonegunmanb <lonegunmanb@hotmail.com> Co-authored-by: Ryan Davis <ryepup@gmail.com> Co-authored-by: Jonathan Sokolowski <jsok@users.noreply.github.com> Co-authored-by: bikerpatch <67706998+bikerpatch@users.noreply.github.com> Co-authored-by: Heng Lu <henglu@microsoft.com>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFAICS this is needed and also stated somehow here #2049 but was never actually done.