Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_automanage_configuration - support new property block backup and azure_security_baseline #22081

Merged
merged 5 commits into from
Jun 8, 2023

Conversation

liuwuliuyun
Copy link
Contributor

@liuwuliuyun liuwuliuyun commented Jun 8, 2023

This is the second PR for azurerm_automanage_configuration, In this PR,

  • new property block backup and azure_security_baseline are added.
  • add test cases for new properties.
  • update documents for new properties.
  • rewrite the expand and flatten logic for better understading and more logical.
  • update the order of struct to be alphabetical.

Previous PR: #21490

Swagger Link: https://github.com/Azure/azure-rest-api-specs/blob/main/specification/automanage/resource-manager/Microsoft.Automanage/stable/2022-05-04/automanage.json

@liuwuliuyun
Copy link
Contributor Author

Testing evidence:

GOROOT=C:\Program Files\Go #gosetup
GOPATH=C:\Users\yunliu1\go #gosetup
"C:\Program Files\Go\bin\go.exe" test -c -o C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand___go_test_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe github.com/hashicorp/terraform-provider-azurerm/internal/services/automanage #gosetup
"C:\Program Files\Go\bin\go.exe" tool test2json -t C:\Users\yunliu1\AppData\Local\JetBrains\GoLand2023.1\tmp\GoLand___go_test_github_com_hashicorp_terraform_provider_azurerm_internal_services_automanage.test.exe -test.v -test.paniconexit0 #gosetup
=== RUN TestAccAutoManageConfigurationProfile_basic
=== PAUSE TestAccAutoManageConfigurationProfile_basic
=== CONT TestAccAutoManageConfigurationProfile_basic
--- PASS: TestAccAutoManageConfigurationProfile_basic (168.02s)
=== RUN TestAccAutoManageConfigurationProfile_antimalware
=== PAUSE TestAccAutoManageConfigurationProfile_antimalware
=== CONT TestAccAutoManageConfigurationProfile_antimalware
--- PASS: TestAccAutoManageConfigurationProfile_antimalware (210.23s)
=== RUN TestAccAutoManageConfigurationProfile_azureSecurityBaseline
=== PAUSE TestAccAutoManageConfigurationProfile_azureSecurityBaseline
=== CONT TestAccAutoManageConfigurationProfile_azureSecurityBaseline
--- PASS: TestAccAutoManageConfigurationProfile_azureSecurityBaseline (248.99s)
=== RUN TestAccAutoManageConfigurationProfile_requiresImport
=== PAUSE TestAccAutoManageConfigurationProfile_requiresImport
=== CONT TestAccAutoManageConfigurationProfile_requiresImport
--- PASS: TestAccAutoManageConfigurationProfile_requiresImport (169.75s)
=== RUN TestAccAutoManageConfigurationProfile_backup
=== PAUSE TestAccAutoManageConfigurationProfile_backup
=== CONT TestAccAutoManageConfigurationProfile_backup
--- PASS: TestAccAutoManageConfigurationProfile_backup (255.55s)
=== RUN TestAccAutoManageConfigurationProfile_complete
=== PAUSE TestAccAutoManageConfigurationProfile_complete
=== CONT TestAccAutoManageConfigurationProfile_complete
--- PASS: TestAccAutoManageConfigurationProfile_complete (174.90s)
=== RUN TestAccAutoManageConfigurationProfile_update
=== PAUSE TestAccAutoManageConfigurationProfile_update
=== CONT TestAccAutoManageConfigurationProfile_update
--- PASS: TestAccAutoManageConfigurationProfile_update (216.29s)
PASS

Process finished with the exit code 0

Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌵

@katbyte katbyte merged commit 91b444f into hashicorp:main Jun 8, 2023
@github-actions github-actions bot added this to the v3.60.0 milestone Jun 8, 2023
katbyte added a commit that referenced this pull request Jun 8, 2023
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
@liuwuliuyun liuwuliuyun deleted the automanage-2 branch September 19, 2024 06:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants