Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubernetes_cluster_node_pool: Fix race condition with virtual network status when creating node pool #25888

Merged
merged 2 commits into from
May 16, 2024

Commits on May 10, 2024

  1. Fix race condition when creating multiple node pools.

    Related to hashicorp#13105
    
    ```
    ❯  make acctests SERVICE='containers' TESTARGS='-run=TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition' TESTTIMEOUT='60m'
    ==> Checking that code complies with gofmt requirements...
    ==> Checking that Custom Timeouts are used...
    ==> Checking that acceptance test packages are used...
    TF_ACC=1 go test -v ./internal/services/containers -run=TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition -timeout 60m -ldflags="-X=github.com/hashicorp/terraform-provider-azurerm/version.ProviderVersion=acc"
    === RUN   TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition
    === PAUSE TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition
    === CONT  TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition
    --- PASS: TestAccKubernetesClusterNodePool_virtualNetworkOwnershipRaceCondition (1395.32s)
    PASS
    ok  	github.com/hashicorp/terraform-provider-azurerm/internal/services/containers	1398.094s
    ```
    
    blah
    c4milo committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1a13a71 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. kubernetes_cluster_node_pool: Address PR reviews

    Co-authored-by: Tom Harvey <tombuildsstuff@users.noreply.github.com>
    Co-authored-by: stephybun <stephybun@users.noreply.github.com>
    3 people committed May 16, 2024
    Configuration menu
    Copy the full SHA
    3042c09 View commit details
    Browse the repository at this point in the history