Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azurerm_firewall_policy: deprecate dns #9331

Closed

Conversation

magodo
Copy link
Collaborator

@magodo magodo commented Nov 16, 2020

This is due to service no longer accept it for all API versions.

fixes #9312

Test Result

💤 make testacc TEST=./azurerm/internal/services/network/tests TESTARGS='-run "TestAccDataSourceFirewallPolicy_|TestAccAzureRMFirewallPolicy_"'                                                                                                                                           
==> Checking that code complies with gofmt requirements...                                                                                   
==> Checking that Custom Timeouts are used...                                                                                                
==> Checking that acceptance test packages are used...                                                                                       
TF_ACC=1 go test ./azurerm/internal/services/network/tests -v -run "TestAccDataSourceFirewallPolicy_|TestAccAzureRMFirewallPolicy_" -timeout 180m -ldflags="-X=github.com/terraform-providers/terraform-provider-azurerm/version.ProviderVersion=acc"
=== RUN   TestAccDataSourceFirewallPolicy_basic                                                                                              
=== PAUSE TestAccDataSourceFirewallPolicy_basic                                                                                              
=== RUN   TestAccAzureRMFirewallPolicy_basic                                                                                                 
=== PAUSE TestAccAzureRMFirewallPolicy_basic                                                                                                 
=== RUN   TestAccAzureRMFirewallPolicy_complete                                                                                              
=== PAUSE TestAccAzureRMFirewallPolicy_complete                                                                                              
=== RUN   TestAccAzureRMFirewallPolicy_update                                                                                                                                                                                                                                             
=== PAUSE TestAccAzureRMFirewallPolicy_update                                                                                                
=== RUN   TestAccAzureRMFirewallPolicy_requiresImport                                                                                        
=== PAUSE TestAccAzureRMFirewallPolicy_requiresImport                                                                                        
=== RUN   TestAccAzureRMFirewallPolicy_inherit                                                                                               
=== PAUSE TestAccAzureRMFirewallPolicy_inherit                                                                                               
=== CONT  TestAccDataSourceFirewallPolicy_basic                                                                                              
=== CONT  TestAccAzureRMFirewallPolicy_update                                                                                                
=== CONT  TestAccAzureRMFirewallPolicy_complete                                                                                              
=== CONT  TestAccAzureRMFirewallPolicy_inherit                                                                                               
=== CONT  TestAccAzureRMFirewallPolicy_basic                                                                                                 
=== CONT  TestAccAzureRMFirewallPolicy_requiresImport                                                                                        
--- PASS: TestAccAzureRMFirewallPolicy_complete (128.23s)                                                                                    
--- PASS: TestAccAzureRMFirewallPolicy_basic (130.44s)                                                                                       
--- PASS: TestAccAzureRMFirewallPolicy_requiresImport (138.42s)                                                                              
--- PASS: TestAccAzureRMFirewallPolicy_inherit (150.94s)                                                                                     
--- PASS: TestAccDataSourceFirewallPolicy_basic (157.76s)                                                                                    
--- PASS: TestAccAzureRMFirewallPolicy_update (233.07s)                                                                                      
PASS                                                                  
ok      github.com/terraform-providers/terraform-provider-azurerm/azurerm/internal/services/network/tests       233.118s          

This is due to service no longer accept it for all API versions.
@magodo
Copy link
Collaborator Author

magodo commented Nov 16, 2020

Close in favor of #9332

@magodo magodo closed this Nov 16, 2020
@ghost
Copy link

ghost commented Dec 16, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

azurerm_firewall_policy deprecated dns property
1 participant