Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQUEST] Enable Accelerated Networking #106

Closed
jbmcfarlin31 opened this issue Sep 4, 2019 · 5 comments
Closed

[REQUEST] Enable Accelerated Networking #106

jbmcfarlin31 opened this issue Sep 4, 2019 · 5 comments

Comments

@jbmcfarlin31
Copy link

I was comparing the options between azurerm and azure stack, and being involved with a support call today made me look deeper... I noticed azure stack nics have capabilities for enabling accelerated networking - but when I looked in terraform, I did not see the option.

Is this feature going to be implemented in the future? Is it already enabled?

The reference link is here

Thanks!

@jbmcfarlin31
Copy link
Author

UPDATE:

I actually noticed this was already implemented in azurestack/resource_arm_network_interace.go, however it was commented out. I verified with the API profile version that supports it and the new profile does support it.

I un-commented the areas that were commented out pertaining to accelerated networking and rebuilt the binary. The binary built successfully, and upon testing it I ran into a problem pertaining to my specific azure stack location in my environment (unrelated to the binary or this code).

I am about 99% confident it will work - but standby and I will clarify when I can...
Thanks!

@jbmcfarlin31
Copy link
Author

Well, in talking with Microsoft in regards to a separate issue, I found out that Azure Stack does not support accelerated networking as of yet. You can find a list of the differences between Azure and Azure Stack here.

My guess is it might come down the pipeline later on. This is why when trying to provision with it enabled in terraform I kept getting the error Accelerated Networking is not Enabled for your location.

@jbpaux
Copy link

jbpaux commented Mar 5, 2020

I think we should close this issue as it's not relevant, and not en enhancement.

@jbmcfarlin31
Copy link
Author

I think we should close this issue as it's not relevant, and not en enhancement.

@jbpaux It would be an enhancement once azure stack adds support for it. That being said, I don't know when that would come down the pipeline (if at all). I don't understand how it is not relevant, other than it currently is not supported in azure stack.

We can close if you feel the need to and just re-open when/and if the feature comes.

@ghost
Copy link

ghost commented Apr 9, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants