Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PSC Connection ID #11767

Closed

Conversation

nielsbox
Copy link

@nielsbox nielsbox commented May 25, 2022

This is my first contribution here so just a heads up if I forget anything.

Adds psc_connection_id as an output of the global_forwarding_rule.
Issue: #10588

Requires: GoogleCloudPlatform/declarative-resource-client-library#11

@nielsbox nielsbox force-pushed the feature/expose-psc-connection-id branch from df2bfdf to ad8dfdd Compare May 25, 2022 12:35
@megan07
Copy link
Contributor

megan07 commented May 25, 2022

Hi @nielsbox, thank you for your contribution! This resource is generated by our upstream repository (magic-modules). Would you mind making the changes there so they can propagate to both google and google-beta providers? Thanks!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants