Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do dependency update in resourceDiff #771 #855

Merged
merged 2 commits into from
Sep 11, 2022

Conversation

WarpRat
Copy link
Contributor

@WarpRat WarpRat commented Apr 27, 2022

Description

Adding the dependency update function earlier in the provider flow. Currently attempting to use a template from a subchart in a template in the parent chart fails if linting or if the experimental manifest feature is enabled. Both the acceptance test and some local testing with the provider changes fix these issues. Running the new test without the dependency update change in resource_release.go fails as expected.

Fixes #771

Acceptance tests

  • Have you added an acceptance test for the functionality being added?

Release Note

Release note for CHANGELOG:

The resourceDiff function now respects the dependency_update setting which fixes a bug in charts with dependencies that use linting or the experimental manifests feature.

References

#771

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 27, 2022

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added size/S and removed size/XS labels May 3, 2022
@WarpRat WarpRat marked this pull request as ready for review May 3, 2022 01:10
@WarpRat WarpRat changed the title Draft: do dependency update in resourceDiff #771 Do dependency update in resourceDiff #771 May 3, 2022
Copy link
Contributor

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @WarpRat

@jrhouston jrhouston merged commit 52d9465 into hashicorp:main Sep 11, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependency_update should be done prior to lint
3 participants