-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for setting kube version on data.helm_template. #985
Add support for setting kube version on data.helm_template. #985
Conversation
Can see that there already is an open PR for this. Apparently my searching skills today was so-so. #917 . |
@nuttmeister Hello! Thank you for opening this PR. It all looks great, only thing missing is the documentation for the Once the documentation is added we should be able to merge it. |
@BBBmau thanks. I will add it later today. |
@BBBmau hope this is enough docs wise, let me know if more is needed. |
@nuttmeister appreciate this PR, looking for that functionality too |
Thanks for adding the docs! Could you use the description from the helm godoc? Gives a bit of a better description of the https://github.com/helm/helm/blob/v3.10.2/pkg/action/install.go#L92-L94 |
@BBBmau does it look better now? The reason why I phrased it the way I did was for it to be in line with the docs/comments on |
@nuttmeister Thanks again for your contribution! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
When using the
helm_template
data source on a template that has kube version constraints it will fail with an error (unlessv1.20.0
) is within that range.So this PR adds the ability to set the kube-version, much like you can with
helm template --kube-version
.Usage
Acceptance tests
Be able to template where templates require k8s versions > 1.20.0.
Release Note
Release note for CHANGELOG:
References
Fix: #994
Community Note