Cam stitt/policy set params nested vars

[cam-stitt]

Description

This PR adds support for policy set parameters, but also updates the workspace variable resource to utilize the "nested" routes that are now preferred.

The change made in workspace variables is not a breaking change and is backwards compatible with the existing setup.

Testing plan

An example of how to use policy set params:

resource "tfe_organization" "foobar" {
  name  = "tst-terraform"
  email = "admin@company.com"
}
resource "tfe_policy_set" "foobar" {
  name         = "policy-set-test"
  organization = "${tfe_organization.foobar.id}"
}
resource "tfe_policy_set_parameter" "foobar" {
  key          = "key_updated"
  value        = "value_updated"
  sensitive    = true
  policy_set_id = "${tfe_policy_set.foobar.id}"
}

External links

• go-tfe documentation
• API documentation

Output from acceptance tests

Note: I've had a few issues getting them to run locally, still trying to get this part done.

[lafentres]

this is a little bit of a nit, but would it be possible to rename the policy parameter files to have the full name of the resource instead of an abbreviation? resource_tfe_policy_set_parameter.go?

other than that and a couple of questions/comments i had, i think this looks good. i created a few different variables and policy set params, and went through updating different attributes while testing and that all went well.

i'm excited that this PR will fix some of the tests as well 🎉 😀

[lafentres]

nice fix! 👏
was this something where we changed the api but didn't update the provider?

[cam-stitt]

Correct! The API had been updated a while ago, but this seemed to have slipped through.