[TF-13376] Refactor registry module delete method #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenolivia
force-pushed
the
laurenolivia/refactor-registry-module-delete-method
branch
from
b333f45
to
0c6472d
Compare
Uk1288
reviewed
Mar 1, 2024
sebasslash
requested changes
Mar 4, 2024
laurenolivia
force-pushed
the
laurenolivia/refactor-registry-module-delete-method
branch
5 times, most recently
from
2cca617
to
9e482a3
Compare
laurenolivia
commented
Mar 5, 2024
laurenolivia
force-pushed
the
laurenolivia/refactor-registry-module-delete-method
branch
from
4614117
to
0a4c3df
Compare
sebasslash
requested changes
Mar 8, 2024
laurenolivia
force-pushed
the
laurenolivia/refactor-registry-module-delete-method
branch
from
0a4c3df
to
de58ded
Compare
sebasslash
approved these changes
Mar 12, 2024
laurenolivia
deleted the
laurenolivia/refactor-registry-module-delete-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Registry Module
DeleteAPI deprecated and replaced three endpoints (see docs). This ticket is a follow-on, after refactoring the API calls in go-tfe (PR) and releasing those changes in v1.45.0.Remember to:
Testing plan
Nameattr for both resources identicalProviderattr for both resources differentExternal links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See testing.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.