-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for managing health assessment (drift detection) settings on workspaces and organizations #550
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this PR! I smoke tested this PR with the go-tfe PR and things look good. I found one issue that needs to be fixed to test (see the comment), and then there are a few minor suggestions I have.
da8c579
to
4ee58ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! I smoke tested with organization and workspace data sources and resources, and everything is working as expected.
Could you update the data source and resource docs for organization to include the new attribute? And then I think we're good to 🥳
Co-authored-by: Anna Winkler <3526523+annawinkler@users.noreply.github.com>
Co-authored-by: Anna Winkler <3526523+annawinkler@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Co-authored-by: Anna Winkler <3526523+annawinkler@users.noreply.github.com>
Description
This Change is to allow operators to manage the drift detection setting for workspaces.
External links
Include any links here that might be helpful for people reviewing your PR. If there are none, feel free to delete this section.
Relies on:
Output from acceptance tests
Please run applicable acceptance tests locally and include the output here. See TESTS.md to learn how to run acceptance tests.
If you are an external contributor, your contribution(s) will first be reviewed before running them against the project's CI pipeline.