Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support importing gcp_auth_backend #1125

Merged
merged 2 commits into from
Jul 30, 2021

Conversation

benashz
Copy link
Contributor

@benashz benashz commented Jul 29, 2021

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

Closes #795
Relates to #913

Release note for CHANGELOG:

resource/gcp_auth_backend`: Support importing preexisting resource 

Output from acceptance testing:

$ make dev testacc TESTARGS='-run \^TestGCPAuthBackend$$'
==> Checking that code complies with gofmt requirements...
go build -o terraform-provider-vault
mv terraform-provider-vault ~/.terraform.d/plugins/
TF_ACC=1 go test $(go list ./...) -v -run \^TestGCPAuthBackend$ -timeout 120m

[...]

=== RUN   TestGCPAuthBackend
=== RUN   TestGCPAuthBackend/basic
=== RUN   TestGCPAuthBackend/import
--- PASS: TestGCPAuthBackend (0.31s)
    --- PASS: TestGCPAuthBackend/basic (0.15s)
    --- PASS: TestGCPAuthBackend/import (0.16s)
PASS
ok      github.com/hashicorp/terraform-provider-vault/vault     (cached)

Copy link
Member

@tvoran tvoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me!

@benashz benashz merged commit da9050d into master Jul 30, 2021
davidmontoyago pushed a commit to davidmontoyago/terraform-provider-vault that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vault_gcp_auth_backend doesn't support import
2 participants