Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ovf argument validation out of CustomizeDiff #1084

Merged
merged 1 commit into from
May 21, 2020

Conversation

bill-rich
Copy link
Contributor

Moving validation out of CustomizeDiff so that OVF deployment is compatible with having computed values at planning.

@bill-rich bill-rich requested a review from a team May 20, 2020 16:39
@ghost ghost added the size/xs Relative Sizing: Extra-Small label May 20, 2020
Copy link

@jrhouston jrhouston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bill-rich bill-rich merged commit 7350891 into master May 21, 2020
@bill-rich bill-rich deleted the i-move_ovf_checks_from_customizediff branch May 21, 2020 18:18
@ghost
Copy link

ghost commented Jun 22, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 hashibot-feedback@hashicorp.com. Thanks!

@ghost ghost locked and limited conversation to collaborators Jun 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
size/xs Relative Sizing: Extra-Small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants