Return correct tag or tag category for given name #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pointers to Go range variables assigned inside a range end up pointing to the last element iterated to. See https://medium.com/golangspec/range-clause-and-the-address-of-iteration-variable-b1796885d2b7. I don't know if the category slice is sorted alphabetically or otherwise, but if your category is not the last in the list, you will get an unexpected result. Fixes hashicorp#909 Signed-off-by: Sune Keller <absukl@almbrand.dk>
ghost
added
the
aareet
approved these changes
Nov 21, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pointers to Go range variables assigned inside a range end up pointing
to the last element iterated to. See
https://medium.com/golangspec/range-clause-and-the-address-of-iteration-variable-b1796885d2b7.
I don't know if the category slice is sorted alphabetically or
otherwise, but if your category is not the last in the list, you will
get an unexpected result.
Fixes #909