Add name_prefix to aws_iam_policy #10178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2rs2ts
force-pushed
the
master
branch
2 times, most recently
from
45b34ff
to
c1f5b62
Compare
This is intended to behave the same way as name_prefix does in aws_iam_role. Fixes hashicorp#10176
2rs2ts
changed the title
|
Hi @2rs2ts This LGTM! Thanks for the work here: |
jrnt30
pushed a commit
to jrnt30/terraform
that referenced
this pull request
Nov 17, 2016
This is intended to behave the same way as name_prefix does in aws_iam_role. Fixes hashicorp#10176
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
This is intended to behave the same way as name_prefix does in aws_iam_role. Fixes hashicorp#10176
fatmcgav
pushed a commit
to fatmcgav/terraform
that referenced
this pull request
Feb 27, 2017
This is intended to behave the same way as name_prefix does in aws_iam_role. Fixes hashicorp#10176
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to behave the same way as name_prefix does in
aws_iam_role.Fixes #10176
Feedback on the interface change would be highly appreciated. I was able to get the acceptance tests to run successfully thanks to some help from a peer, so I feel pretty confident about this.