Stored dependency handling during plan #28228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
missing CreateBeforeDestroy
A stored dependency is documented as being honored even after it is removed from the configuration, until the referenced resource is destroyed.
The resource configuration was always being used to determine dependencies during refresh, because if there were no changes to a resource, there was no chance to replace any incorrect stored dependencies. Now that we are refreshing during plan, we can determine that a resource has no changes and opt to store the new dependencies immediately. Here we clean up the writeResourceInstanceState calls to no longer modify the resource instance state, removing the `dependencies` argument. Callers are now expected to set the Dependencies field as needed.
Codecov Report
|
jbardin
added
the
0.15-backport
mildwonkey
approved these changes
Mar 30, 2021
alisdair
approved these changes
Mar 30, 2021
Merged
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current configuration was always being used to determine dependencies during refresh, because if there were no changes to a resource, there was no chance to replace any incorrect stored dependencies. Always refreshing dependencies prevented situations that required manual state manipulation while refactoring complex configurations.
The problem this caused however, was that dependencies to resources which had been removed from the configuration but not yet destroy were not being handled in the correct order. To handle orphaned dependencies, they must be maintained in the refreshed state all the way through apply. Now that we are refreshing during plan, we can always merge all the known dependencies (invalid dependency targets are not an error, they are ignored), and only if there is no change to the resource will the current config dependencies be stored immediately.
We can also clean up the
writeResourceInstanceStatecalls to no longer modify the resource instance state argument, and remove thedependenciesargument. Callers are now expected to set theDependenciesfield as needed.Fixes #28193