Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show symbols while input if variable marked as sensitive #29520

Merged
merged 2 commits into from
Dec 16, 2022

Conversation

ComBin
Copy link
Contributor

@ComBin ComBin commented Sep 3, 2021

For example openstack admin password

@hashicorp-cla
Copy link

hashicorp-cla commented Sep 3, 2021

CLA assistant check
All committers have signed the CLA.

@crw
Copy link
Collaborator

crw commented May 20, 2022

Thanks for this submission! We usually require a contribution to have a use case and solution discussed with the maintainers in a Github issue before we will review a pull request. It looks like this PR is similar to this issue: #29609 -- is that correct? I also noticed you seem to have added a binary file in your commit which I believe is a terraform binary - that would need to be removed.

Please let me know if this PR is still relevant and what the use case is that it is solving. Thanks again for the submission!

@crw crw added enhancement waiting-response An issue/pull request is waiting for a response from the community labels May 20, 2022
@vercel
Copy link

vercel bot commented May 21, 2022

@ComBin is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

@ComBin
Copy link
Contributor Author

ComBin commented May 21, 2022

Hello, @crw! Yes, #29609 looks similar. Also i removed binary file from PR.
And case for example, entering a password value for openstack administrator account. While value password marked as sensitive before patch, entering looks like:

$ terraform plan
Acquiring state lock. This may take a few moments...
var.os_passwd
  Openstack admin password

  Enter a value: sdfsfsfsf

After:

$ terraform plan
var.os_passwd
  Openstack admin password

  Enter a value: 

Behavior as while typing SSH password.

@crw crw removed the waiting-response An issue/pull request is waiting for a response from the community label May 23, 2022
@crw
Copy link
Collaborator

crw commented May 23, 2022

Thanks! I appreciate that response. I'll put it on the triage queue!

@jbardin jbardin self-assigned this Dec 13, 2022
@jbardin jbardin merged commit 3cda7a0 into hashicorp:main Dec 16, 2022
@github-actions
Copy link

Reminder for the merging maintainer: if this is a user-visible change, please update the changelog on the appropriate release branch.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants