Refreshing devices list after adding a disk or cdrom controller

[dkalleg]

Without refreshing the devices list, we can't find the controller we just created.

[dkalleg]

@chrislovecnm @stack72 @phinze
Adding folks for visibility, please review at your convenience.

[chrislovecnm]

please log err, or check that it is logged in stack above.

[chrislovecnm]

@dkalleg is this an edge case or should have we caught this in testing?

[thetuxkeeper]

@dkalleg : Interesting. It's the same way I do it in #7154 for the network interfaces. Little sad that we have to spam api calls (create device function with created device as return value would be great)
@chrislovecnm : Since it's all before the Read() I think it's "just" a bug. the tfstate will include the created controller, so the tests won't see it.
Additionally I think (not tested) it will only fail if we add a controller type that wasn't present before (will find the old/wrong one). So we need a test that adds a non-default controller (I think a VM has a controller automatically, should be scsi) or make sure that we have no controllers at all and add one.

[dkalleg]

@stack72 @phinze @thetuxkeeper @chrislovecnm @jen20
Any actionable feedback?

[chrislovecnm]

LGTM!!

[dkalleg]

Thanks @stack72

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.