provider/aws: Added support for redshift destination to firehose delivery streams (supersedes #5304) #7375
Conversation
|
|
||
| s3Configuration := d.Get("s3_configuration").([]interface{}) | ||
| if len(s3Configuration) > 1 { | ||
| return fmt.Errorf("[ERROR] You can only define a single s3_configuration per delivery stream") |
There was a problem hiding this comment.
Is this also true of redshift_configuration?
There was a problem hiding this comment.
We no longer need to do this, we can add MaxItems: 1 to the schema for s3_configuration :)
There was a problem hiding this comment.
Updated in 20314ce, yay less code!
| } | ||
|
|
||
| func createS3Config(d *schema.ResourceData) *firehose.S3DestinationConfiguration { | ||
| s3 := d.Get("s3_configuration").([]interface{})[0].(map[string]interface{}) |
There was a problem hiding this comment.
Just noting the types are guaranteed by helper/schema and the length is guaranteed by Required: true + MaxItems: 1
|
LGTM! |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
This PR continues #5304 to add support for Redshift as a destination for Kinesis Firehose streams (and opens up the way to support ElasticSearch in the future).
It builds off of #5304 and adds:
s3_configurationandredshift_configurationtoTypeList; There Can Be Only One™ (of each) so that's fine and it helps with..TypeList:role_arn=>s3_configuration.0.role_arnComputed,Removed)Some of this is mine, but most of it was generously contributed by @dminnear . The reason for opening this new pr was because I had sat on #5304 for a while, waiting for a good time to introduce a backwards incompatible change (which we get in v0.7.0), and I didn't want to ask them to re-work or add a bunch of things after having waited so patiently for so long.
Running acc tests here: