Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider/digitalocean: trim whitespace from ssh key #8173

Merged
merged 1 commit into from
Aug 14, 2016

Conversation

tam7t
Copy link
Contributor

@tam7t tam7t commented Aug 14, 2016

Fixes #7889

whitespace is trimmed from public_key when retrieving from the DigitalOcean API, resulting in the resource being recreated every run.

@stack72
Copy link
Contributor

stack72 commented Aug 14, 2016

Hi @tam7t

Thanks for the fix here :) This LGTM!

% make testacc TEST=./builtin/providers/digitalocean TESTARGS='-run=TestAccDigitalOceanSSHKey_'
==> Checking that code complies with gofmt requirements...
/Users/stacko/Code/go/bin/stringer
go generate $(go list ./... | grep -v /terraform/vendor/)
2016/08/14 21:37:32 Generated command/internal_plugin_list.go
TF_ACC=1 go test ./builtin/providers/digitalocean -v -run=TestAccDigitalOceanSSHKey_ -timeout 120m
=== RUN   TestAccDigitalOceanSSHKey_importBasic
--- PASS: TestAccDigitalOceanSSHKey_importBasic (3.06s)
=== RUN   TestAccDigitalOceanSSHKey_Basic
--- PASS: TestAccDigitalOceanSSHKey_Basic (1.48s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/digitalocean   4.548s

Paul

@stack72 stack72 merged commit f71646a into hashicorp:master Aug 14, 2016
@tam7t tam7t deleted the do_ssh_key_trim branch August 15, 2016 02:15
kwilczynski pushed a commit to kwilczynski/terraform that referenced this pull request Aug 17, 2016
@ghost
Copy link

ghost commented Apr 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

digitalocean_ssh_key keeps being forced as a new resource
2 participants