Service role is not updated on AWS for a CodeDeploy deployment group #9866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @bandesz Is this still a WIP? |
|
@stack72 according to the guideline I was expecting someone to review it properly and respond to my question about the acceptance tests. Otherwise I'm finished with it. |
|
FYI, I just tested this and it's working as expected :) I am going to go ahead with the merge Thanks for all the work here Paul |
stack72
changed the title
ojongerius
added a commit
to atlassian/terraform
that referenced
this pull request
Dec 8, 2016
…dentials * upstream/master: (79 commits) update CHANGELOG Update panicwrap to pass through all interrupt signals Gracefully stops on SIGTERM website: update website for conditionals vendor: update HIL with conditionals Keep a consistent provider order. Update CHANGELOG.md provider/aws: Forces the api gateway domain name certificates to recreate the resource (hashicorp#10588) Update CHANGELOG.md provider/aws: FIxed the api_gw_domain_name replace operation (hashicorp#10179) Fixed note formatting Explicitly say `count` is not supported by modules (hashicorp#10553) docs/aws: Fix the discrepencies of the emr_cluster documentation (hashicorp#10578) Update CHANGELOG.md Service role is not updated on AWS for a CodeDeploy deployment group (hashicorp#9866) Update CHANGELOG.md provider/datadog hashicorp#9375: Refactor tags to a list instead of a map. (hashicorp#10570) Update the Vagrantfile to resolve package update/installation issue. (hashicorp#9783) docs/aws: Add iam_server_certificate data source to nav bar (hashicorp#10576) Update CHANGELOG.md ...
pielu
pushed a commit
to pielu/terraform
that referenced
this pull request
Dec 20, 2016
* aws/feature/r-instance-net-iface-id: (74 commits) - Properly exercise network_interface_id from AWS SDK - Update Terraform’s documentation Update CHANGELOG.md provider/aws: Forces the api gateway domain name certificates to recreate the resource (hashicorp#10588) Update CHANGELOG.md provider/aws: FIxed the api_gw_domain_name replace operation (hashicorp#10179) Fixed note formatting Explicitly say `count` is not supported by modules (hashicorp#10553) docs/aws: Fix the discrepencies of the emr_cluster documentation (hashicorp#10578) Update CHANGELOG.md Service role is not updated on AWS for a CodeDeploy deployment group (hashicorp#9866) Update CHANGELOG.md provider/datadog hashicorp#9375: Refactor tags to a list instead of a map. (hashicorp#10570) Update the Vagrantfile to resolve package update/installation issue. (hashicorp#9783) docs/aws: Add iam_server_certificate data source to nav bar (hashicorp#10576) Update CHANGELOG.md feat/aws: add iam_server_certificate data source (hashicorp#10558) provider/azurerm: arm_virtual_machine panic fix Update .travis.yml provider/aws: Improved the documentation for EMR Cluster (hashicorp#10563) provider/azurerm: Do not pass an empty string of license_type to AMR VMs (hashicorp#10564) ... # Conflicts: # builtin/providers/aws/resource_aws_instance.go
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description:
I tried to change the service role for a CodeDeploy deployment group. The plan showed the change but it was never applied on AWS.
Affected resources:
Affected version: Terraform v0.7.9-dev (24e5ea8)
I applied the fix in this PR and it works, but the tests doesn't seem to check the real changes. Even if I remove my fix the updated acceptance tests still pass. Is it possible these tests only check for internal state changes and don't validate the AWS changes?
I ran the following acceptance tests:
P.S.: sorry for the whitespace updates, if requested I remove them.