provider/aws: Fix panic when passing statuses to aws_acm_certificate #9990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9989 When passing a list of statuses to the acm_certificate data source, we were trying to cast a schema.TypeList directly to []string We need to do it via an []interface{} and then cast to string when ranging over the results. Without this, we get a panic
stack72
force-pushed
the
b-aws-data-acm
branch
from
fc07c48
to
3b18492
Compare
catsby
reviewed
Nov 9, 2016
catsby
approved these changes
Nov 9, 2016
|
Just to reiterate what @catsby and I spoke about - a PR will follow to add a test for this |
gusmat
pushed a commit
to gusmat/terraform
that referenced
this pull request
Dec 6, 2016
…ashicorp#9990) Fixes hashicorp#9989 When passing a list of statuses to the acm_certificate data source, we were trying to cast a schema.TypeList directly to []string We need to do it via an []interface{} and then cast to string when ranging over the results. Without this, we get a panic
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9989
When passing a list of statuses to the acm_certificate data source, we
were trying to cast a schema.TypeList directly to []string
We need to do it via an []interface{} and then cast to string when
ranging over the results. Without this, we get a panic