Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Add a new condition in workflow #280

Merged
merged 2 commits into from
Apr 28, 2021
Merged

Add a new condition in workflow #280

merged 2 commits into from
Apr 28, 2021

Conversation

andrekolodochka
Copy link
Contributor

The current workflow will automatically close all pull requests. While I understand that it's a desired outcome in the original hashicorp/tfc-guide-example repository, this is not what you'd want in the forked repos. PRs in forked repos will be used to initiate Terraform runs, so they shouldn't be closed automatically.

I've added a condition to the workflow to only close PRs in hashicorp/tfc-guide-example repository.

@github-actions
Copy link

Hi! If you are following the Terraform Cloud Get Started tutorial, please open the PR against your personal fork of this repository. We will automatically close this PR, but if you intended to edit the example itself please feel free to re-open it.

Copy link
Contributor

@im2nguyen im2nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Small suggestion that addresses the concern you brought up (most people won't be able to re-open PR)

.github/workflows/your-fork.yml Outdated Show resolved Hide resolved
@im2nguyen im2nguyen reopened this Apr 26, 2021
Co-authored-by: Tu Nguyen <im2nguyen@users.noreply.github.com>
@andrekolodochka
Copy link
Contributor Author

commenting would work, sounds good. feel free to merge, I don't have write access ;)

@im2nguyen im2nguyen merged commit e45ad2a into hashicorp:master Apr 28, 2021
@im2nguyen
Copy link
Contributor

Thanks @andrekolodochka!

@andrekolodochka andrekolodochka deleted the patch-1 branch April 28, 2021 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants