Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding smb sync folder implementation for windows guests addressing #3699 #4209

Merged
merged 2 commits into from
Oct 7, 2014

Conversation

mwrock
Copy link
Contributor

@mwrock mwrock commented Jul 17, 2014

This allows smb folder syncing with windows guests. CmdKey is used in an elevated command (scheduled task) to add the share credentials to the guests credential store to prevent the the share from losing its credentials or creating annoying login prompts to the user.

@sneal
Copy link
Contributor

sneal commented Jul 17, 2014

This looks good, I'll have to track down a Windows host to try this out. My only concern is that this won't work on Win7/Win2008. I think CmdKey isn't available on those older OSs.

@mwrock
Copy link
Contributor Author

mwrock commented Jul 17, 2014

Sounds good. Not sure about 2k8, but it is in win 7/2k8r.

@emyl
Copy link
Contributor

emyl commented Jul 17, 2014

Just tested on win 2008, cmdkey is available 👍

@digital11
Copy link

When using this patch on a Windows host with multiple interfaces (one of them not routable to my guest, which is using vagrant-vsphere), and Puppet provisioning, I encountered an edge case that had the smb synced_folders using the wrong host address. I ended up defining some global smb overrides that allowed me to specify the default host/user/pass for smb shares in my Vagrantfile: digital11@ec928af

@mwrock
Copy link
Contributor Author

mwrock commented Aug 9, 2014

Ahh. I know why that is and think I know what will fix it. Will try to get that in tonight. Thanks!!

@mwrock
Copy link
Contributor Author

mwrock commented Aug 9, 2014

@digital11 can you pull the latest from my branch and tell me if you still have this issue? I just pushed what I believe to be a fix and verified that things are working for me locally but i dont have access to and multi NIC hosts.

thanks!

@mkuzmin
Copy link
Contributor

mkuzmin commented Aug 12, 2014

The fix works great, please merge it in.

@mwrock
Copy link
Contributor Author

mwrock commented Oct 6, 2014

@sneal : Any chance of getting this merged in? Dont mean to bother you but it appears a few have confirmed this fixes a couple issues and currently smb shared folders are truly broken. Thanks!!

sneal added a commit that referenced this pull request Oct 7, 2014
adding smb sync folder implementation for windows guests addressing #3699
@sneal sneal merged commit 220e4f2 into hashicorp:master Oct 7, 2014
@sneal
Copy link
Contributor

sneal commented Oct 7, 2014

Thanks for the reminder, this looks great.

@mwrock
Copy link
Contributor Author

mwrock commented Oct 7, 2014

Awesome. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants