-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding smb sync folder implementation for windows guests addressing #3699 #4209
Conversation
This looks good, I'll have to track down a Windows host to try this out. My only concern is that this won't work on Win7/Win2008. I think CmdKey isn't available on those older OSs. |
Sounds good. Not sure about 2k8, but it is in win 7/2k8r. |
Just tested on win 2008, |
When using this patch on a Windows host with multiple interfaces (one of them not routable to my guest, which is using vagrant-vsphere), and Puppet provisioning, I encountered an edge case that had the smb synced_folders using the wrong host address. I ended up defining some global smb overrides that allowed me to specify the default host/user/pass for smb shares in my Vagrantfile: digital11@ec928af |
Ahh. I know why that is and think I know what will fix it. Will try to get that in tonight. Thanks!! |
@digital11 can you pull the latest from my branch and tell me if you still have this issue? I just pushed what I believe to be a fix and verified that things are working for me locally but i dont have access to and multi NIC hosts. thanks! |
The fix works great, please merge it in. |
@sneal : Any chance of getting this merged in? Dont mean to bother you but it appears a few have confirmed this fixes a couple issues and currently smb shared folders are truly broken. Thanks!! |
adding smb sync folder implementation for windows guests addressing #3699
Thanks for the reminder, this looks great. |
Awesome. Thanks! |
This allows smb folder syncing with windows guests. CmdKey is used in an elevated command (scheduled task) to add the share credentials to the guests credential store to prevent the the share from losing its credentials or creating annoying login prompts to the user.