Do not ignore the sentinal file when running resume #7059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sentinal file was always being ignored when running the resume command. This is fixed along with allowing provision options to be used with resume. Fixes hashicorp#6787
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Do not ignore the sentinal file when running resume and prevent running provisioners again.
References
The sentinal file was always being ignored when running the resume command. This is fixed along with allowing provision options to be used with resume. The code added aligns with the implementation in the reload command.
BTW, I did a
git bisectto track it back to issue #5815 and commit 6f3ed13. In the case of a resume command there was no options array passed into themachine.actioncall which caused theenv.key?(:provision_ignore_sentinel)check in lib/vagrant/action/builtin/provision.rb to fail andignore_sentinaldefaulted to true.