Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement JWT auth #188

Merged
merged 1 commit into from
May 4, 2021
Merged

Implement JWT auth #188

merged 1 commit into from
May 4, 2021

Conversation

grascm
Copy link
Contributor

@grascm grascm commented Feb 17, 2021

No description provided.

@hashicorp-cla
Copy link

hashicorp-cla commented Feb 17, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@grascm grascm changed the title Implement JWT auth #187 Implement JWT auth Feb 17, 2021
@grascm grascm mentioned this pull request Feb 17, 2021
Closed
@grascm
Copy link
Contributor Author

grascm commented Mar 15, 2021

@jasonodonnell gentle ping 🙂

@jasonodonnell
Copy link
Contributor

Thanks for the ping @grascm, we will take a look at this ASAP! 👍

@jasonodonnell jasonodonnell self-requested a review March 15, 2021 19:44
@grascm
Copy link
Contributor Author

grascm commented Apr 22, 2021

@jasonodonnell another one gentle ping 🙂

jasonodonnell
jasonodonnell suggested changes Apr 22, 2021
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping, I'm taking a look now! In general this looks good but I need to test some stuff.

Small ask: can you remove the dist/index.js change? We prefer to do this build on our end only when we're ready to release new versions.

jasonodonnell
jasonodonnell reviewed Apr 22, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
jasonodonnell
jasonodonnell reviewed Apr 22, 2021
View reviewed changes
action.yml Outdated Show resolved Hide resolved
jasonodonnell
jasonodonnell approved these changes May 4, 2021
View reviewed changes
Copy link
Contributor

@jasonodonnell jasonodonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jasonodonnell jasonodonnell merged commit 9e8f225 into hashicorp:master May 4, 2021
@grascm grascm deleted the jwt branch May 4, 2021 14:59
@jasonodonnell jasonodonnell mentioned this pull request May 6, 2021
Merged
@erickufrin-okta
Copy link

Is there a good setup document that walks through ground-up configuration of JWT auth? I too am familiar with the GitLab implementation and am looking for how I can implement GitHub actions the the same type of auth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichiCoder1 RichiCoder1 RichiCoder1 left review comments

@jasonodonnell jasonodonnell jasonodonnell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@grascm @hashicorp-cla @jasonodonnell @erickufrin-okta @RichiCoder1