Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a better error message when secret not found (follow-up) #306

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Write a better error message when secret not found (follow-up) #306

merged 2 commits into from
Apr 20, 2022

Conversation

swenson
Copy link
Contributor

@swenson swenson commented Apr 20, 2022

This replaces #182 so that we can address additional follow-up comments.

@swenson swenson mentioned this pull request Apr 20, 2022
Closed
@dcmoore-gd
Copy link

Thanks for carrying this forward @swenson!

@swenson
Copy link
Contributor Author

swenson commented Apr 20, 2022

Thanks!

@swenson swenson merged commit 40fb8d7 into master Apr 20, 2022
@swenson swenson deleted the better-404-2 branch April 20, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calvn calvn calvn approved these changes

@jasonodonnell jasonodonnell Awaiting requested review from jasonodonnell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@swenson @dcmoore-gd @calvn @simonjohansson