Add GitHub Auth Engine Tests #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltcarbonell
requested review from
jasonodonnell and
davidadeleon
and removed request for
a team
benchmarktests/target_auth_github.go
Outdated
| Policies string `hcl:"policies,optional"` | ||
| TokenBoundCIDRs string `hcl:"token_bound_cidrs,optional"` | ||
| TokenExplicitMaxTTL string `hcl:"token_explicit_max_ttl,optional"` | ||
| TokenNoDefaultPolicy string `hcl:"token_no_default_policy,optional"` |
There was a problem hiding this comment.
is this supposed to be a bool?
elliesterner
approved these changes
Jul 31, 2023
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
Co-authored-by: Ellie <ellie.sterner@hashicorp.com>
* add disable http2 flag * update comment
* rebase * Update docs/tests/secret-azure.md Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com> * check for required subscription and tenant ID --------- Co-authored-by: davidadeleon <56207066+davidadeleon@users.noreply.github.com>
Add additional check to ensure new lines dont get added the version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add github tests for vault benchmark tooling