Custom value of agent port #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
There was a problem hiding this comment.
Hi @HamzaZo, thanks for the contribution!
This looks good but is missing a few things:
- The health probes need to be updated with the custom port,
- Bats unit tests need to be added to ensure coverage on this new configurable. You can find those in
test/unit.
Thanks again!
|
Hello @jasonodonnell, thanks for the review. I added the missing configs Thanks! |
There was a problem hiding this comment.
Thanks @HamzaZo! It looks like the service will also need unit tests since those values are effected by this configurable as well.
added 2 commits
April 8, 2021 18:10
|
@jasonodonnell I update the configuration, could you check it? Thanks |
Co-authored-by: Jason O'Donnell <2160810+jasonodonnell@users.noreply.github.com>
|
Hi @jasonodonnell, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to set the different port of
AGENT_INJECT_LISTEN, other than the default one.Ref issue