Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose ssh algorithm_signer in web interface (#10114) #10299

Merged
merged 2 commits into from
Nov 10, 2022
Merged

Expose ssh algorithm_signer in web interface (#10114) #10299

merged 2 commits into from
Nov 10, 2022

Conversation

bluestealth
Copy link
Contributor

Implements: #10114

  • Adds allowed values for algorithm_signer to ssh plugin API
  • Adds algorithm_signer as field in UI

@hashicorp-cla
Copy link

hashicorp-cla commented Oct 31, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

bluestealth and others added 2 commits June 8, 2022 09:52
@bluestealth @cipherboy
Expose ssh algorithm_signer in web interface (hashicorp#10114)
93f5316 
* Adds allowed values for algorithm_signer to ssh plugin API
* Adds algorithm_signer as field in UI
@cipherboy
Add changelog entry
a00b405 
Signed-off-by: Alexander Scheel <alex.scheel@hashicorp.com>
@cipherboy
Copy link
Contributor

Hey there @bluestealth! The changes look good to me; I've force-pushed your remote branch to resolve conflicts from another PR that's merged, and added the missing changelog entry.

Thank you!

@cipherboy cipherboy added the ui label Jun 8, 2022
@cipherboy cipherboy added this to the 1.12.0-rc1 milestone Jun 8, 2022
hellobontempo
hellobontempo approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for contributing (and @cipherboy for discovering)

Approving - but waiting to confirm with design before merging

@cipherboy cipherboy mentioned this pull request Sep 4, 2022
Closed
@hellobontempo
Copy link
Contributor

Back on sustaining rotation and just realized I never followed up on this! Had to run tests locally since only backend tests ran on this PR. (Branches that aren't prefixed with ui/ skip UI tests) Merging now!

@hellobontempo hellobontempo merged commit 4670673 into hashicorp:main Nov 10, 2022
@bluestealth bluestealth mentioned this pull request Nov 11, 2022
Merged
@bluestealth
Copy link
Contributor Author

@hellobontempo thanks for merging this! It think I found a bug that is introduced in this PR due to #14006, I opened #17894 for this new "default" value that can be passed in

@bluestealth bluestealth deleted the algorithm_signer branch November 11, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellobontempo hellobontempo hellobontempo approved these changes

@cipherboy cipherboy cipherboy approved these changes

Assignees
No one assigned
Labels
secret/ssh ui
Projects
None yet
Milestone
1.12.0-rc1
Development

Successfully merging this pull request may close these issues.
5 participants
@bluestealth @hashicorp-cla @cipherboy @hellobontempo @kitography