Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of UI/Only show form values if have read access into release/1.9.x #14852

Conversation

hc-github-team-secure-vault-core
Copy link
Collaborator

Backport

This PR is auto-generated from #14794 to be assessed for backporting due to the inclusion of the label backport/1.9.x.

WARNING automatic cherry-pick of commits failed. Commits will require human attention.

The below text is copied from the body of the original PR.


This is a bug fix for when a user without read capabilities (but has update), creates a new version of a secret, then goes back to the previous version and clicks "Create new version+" and the recently created secret is populated in the form fields. Even though the user doesn't have read access - it was cached in the browser from the put request when the user updated the secret

@hashicorp-cla
Copy link

hashicorp-cla commented Apr 1, 2022

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes


1 out of 2 committers have signed the CLA.

  • hellobontempo
  • temp

temp seems not to be a GitHub user.
You need a GitHub account to be able to sign the CLA. If you already have a GitHub account, please add the email address used for this commit to your account.

Have you signed the CLA already but the status is still pending? Recheck it.

@vercel vercel bot temporarily deployed to Preview – vault-storybook April 1, 2022 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 1, 2022 21:06 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 4, 2022 17:14 Inactive
@vercel vercel bot temporarily deployed to Preview – vault-storybook April 4, 2022 18:28 Inactive
@vercel vercel bot temporarily deployed to Preview – vault April 4, 2022 18:28 Inactive
@hellobontempo hellobontempo added ui bug Used to indicate a potential bug labels Apr 4, 2022
@hellobontempo hellobontempo added this to the 1.9.5 milestone Apr 4, 2022
@hellobontempo
Copy link
Contributor

Closing because when binary testing, this change did not resolve the original issue

@hellobontempo hellobontempo deleted the backport/ui/update-no-read-kv-secret-bug/cheaply-central-asp branch April 5, 2022 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants