Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add mount accessor to audit request and responses #15342

Merged
merged 3 commits into from
May 12, 2022
Merged

add mount accessor to audit request and responses #15342

merged 3 commits into from
May 12, 2022

Conversation

swayne275
Copy link
Contributor

@swayne275 swayne275 commented May 9, 2022 •
edited
Loading

No description provided.

@swayne275 swayne275 added this to the 1.11.0-rc1 milestone May 9, 2022
@swayne275 swayne275 marked this pull request as ready for review May 9, 2022 22:36
@swayne275 swayne275 requested review from sgmiller, pmmukh, briankassouf and a team May 9, 2022 22:36
pmmukh
pmmukh approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@pmmukh pmmukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one q, looks solid to me!

ccapurso
ccapurso approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@ccapurso ccapurso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The one suggestion that I have is to provide some basic test coverage.

sgmiller
sgmiller approved these changes May 12, 2022
View reviewed changes
audit/format.go Show resolved Hide resolved
@swayne275 swayne275 merged commit 854a6f4 into main May 12, 2022
@swayne275 swayne275 deleted the vault-6121/mount-alias-in-audit-log branch May 12, 2022 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmmukh pmmukh pmmukh approved these changes

@sgmiller sgmiller sgmiller approved these changes

@ccapurso ccapurso ccapurso approved these changes

@briankassouf briankassouf Awaiting requested review from briankassouf

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.11.0-rc1
Development

Successfully merging this pull request may close these issues.
4 participants
@swayne275 @ccapurso @sgmiller @pmmukh