Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: fix jwt auth failure #16466

Merged
merged 6 commits into from
Jul 27, 2022
Merged

UI: fix jwt auth failure #16466

merged 6 commits into from
Jul 27, 2022

Conversation

hashishaw
Copy link
Contributor

@hashishaw hashishaw commented Jul 27, 2022

A bug was introduced with #14545 which caused JWT auth attempts to fail because it was attempting to login with the wrong URL.

As part of this work I also added an acceptance test for JWT that ensures the correct endpoint and body params are passed.

This PR addresses #15223

@hashishaw hashishaw added ui bug Used to indicate a potential bug backport/1.9.x labels Jul 27, 2022
@hashishaw hashishaw added this to the 1.9.9 milestone Jul 27, 2022
@hashishaw hashishaw linked an issue Jul 27, 2022 that may be closed by this pull request
Copy link
Contributor

@hellobontempo hellobontempo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tackling! And adding tests 😍

Edit: just saw some UI pki tests are failing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Used to indicate a potential bug ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JWT login not working in UI
2 participants