Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: CLI improvement VAULT_ADDR Warning message #17076

Merged
merged 9 commits into from
Oct 30, 2023
Merged

Core: CLI improvement VAULT_ADDR Warning message #17076

merged 9 commits into from
Oct 30, 2023

Conversation

aphorise
Copy link
Contributor

@aphorise aphorise commented Sep 9, 2022 •
edited
Loading

When VAULT_ADDR or -address is not set provide warning messages as below. Resolves #9684.

./vault status
  # WARNING! VAULT_ADDR and -address unset. Defaulting to https://127.0.0.1:8200.
  # Error checking seal status: Get "https://127.0.0.1:8200/v1/sys/seal-status": dial tcp 127.0.0.1:8200: connect: connection refused

Supersedes PR: #17008

@aphorise aphorise requested a review from mpalmi September 9, 2022 14:07
mpalmi
mpalmi approved these changes Sep 9, 2022
View reviewed changes
Copy link
Contributor

@mpalmi mpalmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! There's a typo in the PR name: s/imporvement/improvement/, but other than that it should be good to go!

@aphorise aphorise changed the title Core: CLI imporvement VAULT_ADDR Warning message. Resolves #9684. Core: CLI improvement VAULT_ADDR Warning message. Resolves #9684. Sep 9, 2022
@aphorise aphorise changed the title Core: CLI improvement VAULT_ADDR Warning message. Resolves #9684. Core: CLI improvements VAULT_ADDR Warning message. Resolves #9684. Sep 9, 2022
@aphorise aphorise changed the title Core: CLI improvements VAULT_ADDR Warning message. Resolves #9684. Core: CLI improvement VAULT_ADDR Warning message. Resolves #9684. Sep 9, 2022
@mpalmi mpalmi changed the title Core: CLI improvement VAULT_ADDR Warning message. Resolves #9684. Core: CLI improvement VAULT_ADDR Warning message Sep 12, 2022
This was referenced Sep 12, 2022
Closed
Closed
@aphorise
Copy link
Contributor Author

hey @mpalmi this doesnt seems to have made it out with the 1.12 GA release.

ncabatoff
ncabatoff reviewed Jan 24, 2023
View reviewed changes
command/base.go Outdated Show resolved Hide resolved
ncabatoff
ncabatoff reviewed Jan 25, 2023
View reviewed changes
command/base.go Outdated Show resolved Hide resolved
ncabatoff
ncabatoff reviewed May 31, 2023
View reviewed changes
command/base.go Outdated Show resolved Hide resolved
ncabatoff
ncabatoff reviewed May 31, 2023
View reviewed changes
command/base.go Outdated Show resolved Hide resolved
cipherboy
cipherboy previously requested changes May 31, 2023
View reviewed changes
command/base.go Outdated Show resolved Hide resolved
@aphorise aphorise dismissed cipherboy’s stale review June 1, 2023 13:41

Fixed by moving message a few lines lower where tests are now passing without any issue.

@ncabatoff ncabatoff self-requested a review June 1, 2023 18:10
@VioletHynes VioletHynes added the hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed label Jul 7, 2023
@github-actions
Copy link

github-actions bot commented Sep 12, 2023 •
edited
Loading

Build Results:
All builds succeeded! ✅

@aphorise
Copy link
Contributor Author

@ncabatoff @cipherboy thank you for all the insight and input on this.

Given the most recent changes - when is this likely to get merged and is it likely to be part of 1.15 GA?

@ncabatoff ncabatoff merged commit 40e00d8 into main Oct 30, 2023
68 of 69 checks passed
@ncabatoff ncabatoff deleted the cli/address-warning branch October 30, 2023 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipherboy cipherboy cipherboy left review comments

@mpalmi mpalmi mpalmi approved these changes

@ncabatoff ncabatoff ncabatoff approved these changes

Assignees
No one assigned
Labels
hashicorp-contributed-pr If the PR is HashiCorp (i.e. not-community) contributed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

request: improve vault login error message to help the newbie
5 participants
@aphorise @cipherboy @ncabatoff @mpalmi @VioletHynes