fix: upgrade vault-plugin-secrets-gcpkms to v0.13.0 #17199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
austingebauer
approved these changes
Sep 19, 2022
There was a problem hiding this comment.
LGTM. Could add changelog similar to https://github.com/hashicorp/vault/pull/17174/files (but omit the go-gcp-common dep).
Something like:
```release-note:improvement
secrets/gcpkms: Updates dependency google.golang.org/api@v0.83.0.
```
benashz
force-pushed
the
update-plugin-vault-plugin-secrets-gcpkms-v0.13.0
branch
from
e7bf248
to
8632272
Compare
benashz
deleted the
update-plugin-vault-plugin-secrets-gcpkms-v0.13.0
branch
| @@ -0,0 +1,3 @@ | |||
| ```release-note:improvement | |||
| secrets/gcp: Update `github.com/hashicorp/vault-plugin-secrets-gcpkms` to `v0.13.0`. | |||
There was a problem hiding this comment.
Oh shoot, I meant to suggest a CL update for what actually changed in the plugin itself instead of this version bump in Vault. The change in the plugin itself is that we updated its google.golang.org/api dependency to v0.83.0. I think the CL entry that I placed in my other comment is the one we need.
Exactly like this:
```release-note:improvement
secrets/gcpkms: Updates `google.golang.org/api` dependency to `v0.83.0`.
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.