VAULT-6938 Remove license from being cache exempt #17265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
approved these changes
Sep 21, 2022
|
Oh, good point regarding the 1.11 removal of stored license support. I even tested that feature and forgot about it when implementing this! Well, even more reason to take the path off the exempt list, I guess. |
ncabatoff
reviewed
Sep 26, 2022
ncabatoff
approved these changes
Sep 26, 2022
Co-authored-by: Nick Cabatoff <ncabatoff@hashicorp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
License reading still seems to work, from my tests with this commit in ent, and all relevant tests I could find (e.g. all of the licensing tests in the
vaultpackage) seem to pass.