VAULT-8518 Increase HMAC limit to 4096, and limit approle names to the same limit #17768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpalmi
approved these changes
Nov 2, 2022
hghaf099
approved these changes
Nov 2, 2022
| @@ -0,0 +1,3 @@ | |||
| ```release-note:change | |||
| auth/approle: Add maximum length of 4096 for approle role_names, as this value results in HMAC calculation | |||
There was a problem hiding this comment.
I am bit confused by this phrase. Do you mean that HMAC result is of length 4096?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #14746, we restricted the length of approle's HMAC to 1024. This had the unfortunate effect of making it so that operations on an approle with such a name would fail.
As part of this change, I've increased the limit slightly, so that it's more permissive to names, but also made approle creation fail if the name passes this limit, so that we cannot get into this state to begin with.