Fix activity log end time #17856
Merged
Fix activity log end time #17856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccapurso
reviewed
Nov 10, 2022
mpalmi
approved these changes
Nov 10, 2022
This was referenced Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell, I think the activity log endpoint is returning the correct data, but it's not adjusting the
end_timethat's returned when we calculate partial month counts. Instead, it was always using the end time for the pre-computed query. This meant that the end_time returned didn't accurately reflect the actual data. Now it should.For more detail see https://hashicorp.atlassian.net/browse/VAULT-9257