-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: fixes link from to show page from entity policies list #17950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I wonder how this worked in the first place if the model was being unloaded on route change by that mixin? Maybe something changed in the run loop timing or something in the new version.
A few policy tests are failing but I'm guessing they just need to be updated to have |
It ended up being more complicated than that...updated the template so that tests pass. I'm not sure if changing the capabilities check from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not familiar with the capabilities model but it looks to me like using lazyCapabilities on the policy model itself is more appropriate. It might be a good idea to get another set of eyes on this just to be sure.
this PR previously addressed a capabilities issue in the show template, but we decided to approach the solution another day and get to the root of the problem (rather than supply a bandaid fix)