-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow alias dereferencing in LDAP searches #18230
Conversation
@f4z3r is attempting to deploy a commit to the HashiCorp Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: tjperry07 <tjperry07@users.noreply.github.com>
This does look like a good feature addition to LDAP auth. @hashicorp/vault-admin please have a look? Thanks |
Chiming in on behalf of the Vault-admin group - it looks like we've reviewed the documentation portion of the PR, but so far no one has reviewed the code changes. I've nudged this PR internally, but I don't currently have an idea of when there might be further updates. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @f4z3r thanks for taking care of this.
I verified if the default value is indeed "never" for backward compatibility, checked that the new parameter is passed correctly both as input and output on the API and that it is used to populate the ldap search requests where ever a search was performed and everything looks covered.
I just have a small suggestion to document the dereference_aliases
param on the api-docs page for completeness and this would be good to ship!
Thanks for updating the api-docs, everything looks good to me! |
Implements the requested improvement from #6128