Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alias dereferencing in LDAP searches #18230

Merged
merged 7 commits into from
Feb 24, 2023
Merged

Conversation

f4z3r
Copy link
Contributor

@f4z3r f4z3r commented Dec 5, 2022

Implements the requested improvement from #6128

@f4z3r f4z3r requested a review from a team December 5, 2022 19:26
@f4z3r f4z3r requested a review from tjperry07 as a code owner December 8, 2022 13:56
@vercel
Copy link

vercel bot commented Dec 8, 2022

@f4z3r is attempting to deploy a commit to the HashiCorp Team on Vercel.

A member of the Team first needs to authorize it.

website/content/docs/auth/ldap.mdx Outdated Show resolved Hide resolved
Co-authored-by: tjperry07 <tjperry07@users.noreply.github.com>
@jboero
Copy link

jboero commented Feb 21, 2023

This does look like a good feature addition to LDAP auth. @hashicorp/vault-admin please have a look? Thanks

@mladlow
Copy link
Collaborator

mladlow commented Feb 21, 2023

Chiming in on behalf of the Vault-admin group - it looks like we've reviewed the documentation portion of the PR, but so far no one has reviewed the code changes. I've nudged this PR internally, but I don't currently have an idea of when there might be further updates.

Copy link
Contributor

@maxcoulombe maxcoulombe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @f4z3r thanks for taking care of this.

I verified if the default value is indeed "never" for backward compatibility, checked that the new parameter is passed correctly both as input and output on the API and that it is used to populate the ldap search requests where ever a search was performed and everything looks covered.

I just have a small suggestion to document the dereference_aliases param on the api-docs page for completeness and this would be good to ship!

website/content/docs/auth/ldap.mdx Show resolved Hide resolved
@f4z3r f4z3r requested a review from yhyakuna as a code owner February 23, 2023 17:08
@maxcoulombe
Copy link
Contributor

Thanks for updating the api-docs, everything looks good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants